From e6f32eea742fec0509550e2d865e215aa07d3318 Mon Sep 17 00:00:00 2001 From: Di Xu Date: Sat, 1 Sep 2018 17:40:29 +0800 Subject: [PATCH] verifying LimitRange update is effective before creating new pod --- test/e2e/scheduling/limit_range.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/test/e2e/scheduling/limit_range.go b/test/e2e/scheduling/limit_range.go index 98ce1878a1b..dc68705ad58 100644 --- a/test/e2e/scheduling/limit_range.go +++ b/test/e2e/scheduling/limit_range.go @@ -18,6 +18,7 @@ package scheduling import ( "fmt" + "reflect" "time" "k8s.io/api/core/v1" @@ -81,6 +82,7 @@ var _ = SIGDescribe("LimitRange", func() { By("Fetching the LimitRange to ensure it has proper values") limitRange, err = f.ClientSet.CoreV1().LimitRanges(f.Namespace.Name).Get(limitRange.Name, metav1.GetOptions{}) + Expect(err).NotTo(HaveOccurred()) expected := v1.ResourceRequirements{Requests: defaultRequest, Limits: defaultLimit} actual := v1.ResourceRequirements{Requests: limitRange.Spec.Limits[0].DefaultRequest, Limits: limitRange.Spec.Limits[0].Default} err = equalResourceRequirement(expected, actual) @@ -140,6 +142,13 @@ var _ = SIGDescribe("LimitRange", func() { limitRange, err = f.ClientSet.CoreV1().LimitRanges(f.Namespace.Name).Update(limitRange) Expect(err).NotTo(HaveOccurred()) + By("Verifying LimitRange updating is effective") + Expect(wait.Poll(time.Second*2, time.Second*20, func() (bool, error) { + limitRange, err = f.ClientSet.CoreV1().LimitRanges(f.Namespace.Name).Get(limitRange.Name, metav1.GetOptions{}) + Expect(err).NotTo(HaveOccurred()) + return reflect.DeepEqual(limitRange.Spec.Limits[0].Min, newMin), nil + })).NotTo(HaveOccurred()) + By("Creating a Pod with less than former min resources") pod = f.NewTestPod(podName, getResourceList("10m", "50Mi", "50Gi"), v1.ResourceList{}) pod, err = f.ClientSet.CoreV1().Pods(f.Namespace.Name).Create(pod)