From 394db3b407c55c8fc910ca6ba0cb1f005213697e Mon Sep 17 00:00:00 2001 From: Wojciech Tyczynski Date: Mon, 6 Jun 2016 10:49:46 +0200 Subject: [PATCH] Fix traces --- pkg/storage/etcd/etcd_helper.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/pkg/storage/etcd/etcd_helper.go b/pkg/storage/etcd/etcd_helper.go index 40c9337a061..3de60374396 100644 --- a/pkg/storage/etcd/etcd_helper.go +++ b/pkg/storage/etcd/etcd_helper.go @@ -136,8 +136,8 @@ func (h *etcdHelper) Create(ctx context.Context, key string, obj, out runtime.Ob PrevExist: etcd.PrevNoExist, } response, err := h.etcdKeysAPI.Set(ctx, key, string(data), &opts) - metrics.RecordEtcdRequestLatency("create", getTypeName(obj), startTime) trace.Step("Object created") + metrics.RecordEtcdRequestLatency("create", getTypeName(obj), startTime) if err != nil { return toStorageErr(err, key, 0) } @@ -335,9 +335,8 @@ func (h *etcdHelper) GetToList(ctx context.Context, key string, filter storage.F Quorum: h.quorum, } response, err := h.etcdKeysAPI.Get(ctx, key, opts) - - metrics.RecordEtcdRequestLatency("get", getTypeName(listPtr), startTime) trace.Step("Etcd node read") + metrics.RecordEtcdRequestLatency("get", getTypeName(listPtr), startTime) if err != nil { if etcdutil.IsEtcdNotFound(err) { return nil @@ -415,8 +414,8 @@ func (h *etcdHelper) List(ctx context.Context, key string, resourceVersion strin startTime := time.Now() trace.Step("About to list etcd node") nodes, index, err := h.listEtcdNode(ctx, key) - metrics.RecordEtcdRequestLatency("list", getTypeName(listPtr), startTime) trace.Step("Etcd node listed") + metrics.RecordEtcdRequestLatency("list", getTypeName(listPtr), startTime) if err != nil { return err }