From e742c31f9735d60bcd15ac56e9ae31d065feaebd Mon Sep 17 00:00:00 2001 From: gmarek Date: Wed, 9 Aug 2017 13:59:37 +0200 Subject: [PATCH] Don't call one of pointless conversions --- .../util/eventsink/eventsink.go | 21 +++---------------- 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/federation/pkg/federation-controller/util/eventsink/eventsink.go b/federation/pkg/federation-controller/util/eventsink/eventsink.go index 8a7ca0a72e9..343fef5df73 100644 --- a/federation/pkg/federation-controller/util/eventsink/eventsink.go +++ b/federation/pkg/federation-controller/util/eventsink/eventsink.go @@ -72,12 +72,7 @@ func init() { } func (fes *FederatedEventSink) Create(event *v1.Event) (*v1.Event, error) { - kubeEvent := &v1.Event{} - if err := scheme.Convert(event, kubeEvent, nil); err != nil { - return nil, err - } - - ret, err := fes.clientset.Core().Events(kubeEvent.Namespace).Create(kubeEvent) + ret, err := fes.clientset.Core().Events(event.Namespace).Create(event) if err != nil { return nil, err } @@ -90,12 +85,7 @@ func (fes *FederatedEventSink) Create(event *v1.Event) (*v1.Event, error) { } func (fes *FederatedEventSink) Update(event *v1.Event) (*v1.Event, error) { - kubeEvent := &v1.Event{} - if err := scheme.Convert(event, kubeEvent, nil); err != nil { - return nil, err - } - - ret, err := fes.clientset.Core().Events(kubeEvent.Namespace).Update(kubeEvent) + ret, err := fes.clientset.Core().Events(event.Namespace).Update(event) if err != nil { return nil, err } @@ -108,12 +98,7 @@ func (fes *FederatedEventSink) Update(event *v1.Event) (*v1.Event, error) { } func (fes *FederatedEventSink) Patch(event *v1.Event, data []byte) (*v1.Event, error) { - kubeEvent := &v1.Event{} - if err := scheme.Convert(event, kubeEvent, nil); err != nil { - return nil, err - } - - ret, err := fes.clientset.Core().Events(kubeEvent.Namespace).Patch(kubeEvent.Name, types.StrategicMergePatchType, data) + ret, err := fes.clientset.Core().Events(event.Namespace).Patch(event.Name, types.StrategicMergePatchType, data) if err != nil { return nil, err }