github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-22 19:31:44 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #114905 from kannon92/sync-job-test-fix

Browse Source 
Fix SyncPastDeadlineJobFinished for enabling finalizer path
This commit is contained in:
Kubernetes Prow Robot 2023-01-09 12:47:28 -08:00 committed by GitHub
commit e7549eae87
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/controller/job/job_controller_test.go
View File

@ -1869,6 +1869,9 @@ func TestPastDeadlineJobFinished(t *testing.T) {
start := metav1.NewTime(fakeClock.Now()) start := metav1.NewTime(fakeClock.Now())
job.Status.StartTime = &start job.Status.StartTime = &start
} }
job.Annotations = map[string]string{
batch.JobTrackingFinalizer: "",
}
_, err := clientset.BatchV1().Jobs(job.GetNamespace()).Create(ctx, job, metav1.CreateOptions{}) _, err := clientset.BatchV1().Jobs(job.GetNamespace()).Create(ctx, job, metav1.CreateOptions{})
if err != nil { if err != nil {
@ -1878,6 +1881,10 @@ func TestPastDeadlineJobFinished(t *testing.T) {
if err := sharedInformerFactory.Batch().V1().Jobs().Informer().GetIndexer().Add(job); err != nil { if err := sharedInformerFactory.Batch().V1().Jobs().Informer().GetIndexer().Add(job); err != nil {
t.Fatalf("Failed to insert job in index: %v", err) t.Fatalf("Failed to insert job in index: %v", err)
} }
// This is needed because the fake clientset doesn't report created pods
// to the informer, leading to unsatisfied expectations in syncJob that prevent the controller from setting the final condition.
podIndexer := sharedInformerFactory.Core().V1().Pods().Informer().GetIndexer()
setPodsStatuses(podIndexer, job, 0, 1, 0, 0, 0)
var j *batch.Job var j *batch.Job
err = wait.PollImmediate(200*time.Microsecond, 3*time.Second, func() (done bool, err error) { err = wait.PollImmediate(200*time.Microsecond, 3*time.Second, func() (done bool, err error) {