From e80dcba2974267f2106f53286681072920e5652b Mon Sep 17 00:00:00 2001 From: wenlxie Date: Wed, 29 Nov 2017 13:02:27 +0800 Subject: [PATCH] should check the return value of os.DiskIsAttached --- pkg/cloudprovider/providers/openstack/openstack_volumes.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/cloudprovider/providers/openstack/openstack_volumes.go b/pkg/cloudprovider/providers/openstack/openstack_volumes.go index f670bce6d06..2b5cb7ba24c 100644 --- a/pkg/cloudprovider/providers/openstack/openstack_volumes.go +++ b/pkg/cloudprovider/providers/openstack/openstack_volumes.go @@ -419,7 +419,11 @@ func (os *OpenStack) DiskIsAttached(instanceID, volumeID string) (bool, error) { func (os *OpenStack) DisksAreAttached(instanceID string, volumeIDs []string) (map[string]bool, error) { attached := make(map[string]bool) for _, volumeID := range volumeIDs { - isAttached, _ := os.DiskIsAttached(instanceID, volumeID) + isAttached, err := os.DiskIsAttached(instanceID, volumeID) + if err != nil && err != ErrNotFound { + attached[volumeID] = true + continue + } attached[volumeID] = isAttached } return attached, nil