From f7a091e8ff2313a51c74676d06241ae30eb501cf Mon Sep 17 00:00:00 2001 From: Christoph Blecker Date: Sun, 4 Feb 2018 21:41:12 -0800 Subject: [PATCH 1/4] Add OWNERS for Godeps and vendor folders --- Godeps/OWNERS | 4 ++++ OWNERS_ALIASES | 4 ++++ vendor/OWNERS | 4 ++++ 3 files changed, 12 insertions(+) create mode 100644 Godeps/OWNERS create mode 100644 vendor/OWNERS diff --git a/Godeps/OWNERS b/Godeps/OWNERS new file mode 100644 index 00000000000..9760f98b5bd --- /dev/null +++ b/Godeps/OWNERS @@ -0,0 +1,4 @@ +reviewers: + - vendor-reviewers +approvers: + - vendor-approvers diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES index 8f898647ea1..e86b3f615a1 100644 --- a/OWNERS_ALIASES +++ b/OWNERS_ALIASES @@ -223,3 +223,7 @@ aliases: - piosz - jsafrane - jbeda + vendor-reviewers: + - thockin + vendor-approvers: + - thockin diff --git a/vendor/OWNERS b/vendor/OWNERS new file mode 100644 index 00000000000..9760f98b5bd --- /dev/null +++ b/vendor/OWNERS @@ -0,0 +1,4 @@ +reviewers: + - vendor-reviewers +approvers: + - vendor-approvers From 9f53050229e425ae457598974303f537a0583e9d Mon Sep 17 00:00:00 2001 From: Christoph Blecker Date: Sun, 4 Feb 2018 21:47:07 -0800 Subject: [PATCH 2/4] Add OWNERS for third_party folder --- third_party/OWNERS | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 third_party/OWNERS diff --git a/third_party/OWNERS b/third_party/OWNERS new file mode 100644 index 00000000000..4ca753ad31d --- /dev/null +++ b/third_party/OWNERS @@ -0,0 +1,8 @@ +reviewers: + - lavalamp + - smarterclayton + - thockin +approvers: + - lavalamp + - smarterclayton + - thockin From 1a4ba0caa9633b61d014a6d27357706f1377b740 Mon Sep 17 00:00:00 2001 From: Christoph Blecker Date: Sun, 4 Feb 2018 23:54:07 -0800 Subject: [PATCH 3/4] Add OWNERS for translations folder --- pkg/generated/bindata.go | 24 ++++++++++++++++++++++++ translations/OWNERS | 4 ++++ 2 files changed, 28 insertions(+) create mode 100644 translations/OWNERS diff --git a/pkg/generated/bindata.go b/pkg/generated/bindata.go index 29d7635f68b..2ec40346be0 100644 --- a/pkg/generated/bindata.go +++ b/pkg/generated/bindata.go @@ -1,5 +1,6 @@ // Code generated by go-bindata. // sources: +// translations/OWNERS // translations/extract.py // translations/kubectl/OWNERS // translations/kubectl/de_DE/LC_MESSAGES/k8s.mo @@ -67,6 +68,27 @@ func (fi bindataFileInfo) Sys() interface{} { return nil } +var _translationsOwners = []byte(`reviewers: + - brendandburns +approvers: + - brendandburns +`) + +func translationsOwnersBytes() ([]byte, error) { + return _translationsOwners, nil +} + +func translationsOwners() (*asset, error) { + bytes, err := translationsOwnersBytes() + if err != nil { + return nil, err + } + + info := bindataFileInfo{name: "translations/OWNERS", size: 0, mode: os.FileMode(0), modTime: time.Unix(0, 0)} + a := &asset{bytes: bytes, info: info} + return a, nil +} + var _translationsExtractPy = []byte(`#!/usr/bin/env python # Copyright 2017 The Kubernetes Authors. @@ -19278,6 +19300,7 @@ func AssetNames() []string { // _bindata is a table, holding each asset generator, mapped to its name. var _bindata = map[string]func() (*asset, error){ + "translations/OWNERS": translationsOwners, "translations/extract.py": translationsExtractPy, "translations/kubectl/OWNERS": translationsKubectlOwners, "translations/kubectl/de_DE/LC_MESSAGES/k8s.mo": translationsKubectlDe_deLc_messagesK8sMo, @@ -19345,6 +19368,7 @@ type bintree struct { var _bintree = &bintree{nil, map[string]*bintree{ "translations": {nil, map[string]*bintree{ + "OWNERS": {translationsOwners, map[string]*bintree{}}, "extract.py": {translationsExtractPy, map[string]*bintree{}}, "kubectl": {nil, map[string]*bintree{ "OWNERS": {translationsKubectlOwners, map[string]*bintree{}}, diff --git a/translations/OWNERS b/translations/OWNERS new file mode 100644 index 00000000000..b5535f7410b --- /dev/null +++ b/translations/OWNERS @@ -0,0 +1,4 @@ +reviewers: + - brendandburns +approvers: + - brendandburns From 61b4f176d94dcfed0ff8cb5a34c2600d0fb77fdf Mon Sep 17 00:00:00 2001 From: Christoph Blecker Date: Sun, 4 Feb 2018 23:46:51 -0800 Subject: [PATCH 4/4] Ignore OWNERS file in verify-godeps --- hack/verify-godeps.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hack/verify-godeps.sh b/hack/verify-godeps.sh index 5037f437606..b1ef5aa4224 100755 --- a/hack/verify-godeps.sh +++ b/hack/verify-godeps.sh @@ -101,7 +101,7 @@ pushd "${KUBE_ROOT}" 2>&1 > /dev/null ret=1 fi - if ! _out="$(diff -Naupr -x "BUILD" -x "AUTHORS*" -x "CONTRIBUTORS*" vendor ${_kubetmp}/vendor)"; then + if ! _out="$(diff -Naupr -x "BUILD" -x "OWNERS" -x "AUTHORS*" -x "CONTRIBUTORS*" vendor ${_kubetmp}/vendor)"; then echo "Your vendored results are different:" echo "${_out}" echo "Godeps Verify failed."