github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 05:27:21 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #107042 from kkkkun/update_metrics_bucket

Browse Source 
Update etcdRequestLatency metrics bucket size
This commit is contained in:
Kubernetes Prow Robot 2022-07-16 00:28:52 -07:00 committed by GitHub
commit e8410006ac
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go
View File

@ -94,7 +94,7 @@ var (
// This metric is used for verifying api call latencies SLO, // This metric is used for verifying api call latencies SLO,
// as well as tracking regressions in this aspects. // as well as tracking regressions in this aspects.
// Thus we customize buckets significantly, to empower both usecases. // Thus we customize buckets significantly, to empower both usecases.
Buckets: []float64{0.05, 0.1, 0.2, 0.4, 0.6, 0.8, 1.0, 1.25, 1.5, 2, 3, Buckets: []float64{0.005, 0.025, 0.05, 0.1, 0.2, 0.4, 0.6, 0.8, 1.0, 1.25, 1.5, 2, 3,
4, 5, 6, 8, 10, 15, 20, 30, 45, 60}, 4, 5, 6, 8, 10, 15, 20, 30, 45, 60},
StabilityLevel: compbasemetrics.STABLE, StabilityLevel: compbasemetrics.STABLE,
}, },

6
staging/src/k8s.io/apiserver/pkg/storage/etcd3/metrics/metrics.go
View File

@ -38,7 +38,11 @@ var (
Name: "etcd_request_duration_seconds", Name: "etcd_request_duration_seconds",
Help: "Etcd request latency in seconds for each operation and object type.", Help: "Etcd request latency in seconds for each operation and object type.",
// Etcd request latency in seconds for each operation and object type. // Etcd request latency in seconds for each operation and object type.
Buckets: []float64{0.005, 0.025, 0.1, 0.25, 0.5, 1.0, 2.0, 4.0, 15.0, 30.0, 60.0}, // This metric is used for verifying etcd api call latencies SLO
// keep consistent with apiserver metric 'requestLatencies' in
// staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go
Buckets: []float64{0.005, 0.025, 0.05, 0.1, 0.2, 0.4, 0.6, 0.8, 1.0, 1.25, 1.5, 2, 3,
4, 5, 6, 8, 10, 15, 20, 30, 45, 60},
StabilityLevel: compbasemetrics.ALPHA, StabilityLevel: compbasemetrics.ALPHA,
}, },
[]string{"operation", "type"}, []string{"operation", "type"},

2
test/instrumentation/testdata/stable-metrics-list.yaml vendored
View File

@ -230,6 +230,8 @@
- verb - verb
- version - version
buckets: buckets:
- 0.005
- 0.025
- 0.05 - 0.05
- 0.1 - 0.1
- 0.2 - 0.2