From e8e2fda5c399ef81f16395f6db295a35e3e8ddae Mon Sep 17 00:00:00 2001 From: Sergey Kanzhelev Date: Fri, 21 Jun 2024 17:46:49 +0000 Subject: [PATCH] improve logging of pod admission denied --- pkg/kubelet/cm/topologymanager/topology_manager.go | 1 - pkg/kubelet/eviction/eviction_manager.go | 2 -- pkg/kubelet/kubelet.go | 3 +++ 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/kubelet/cm/topologymanager/topology_manager.go b/pkg/kubelet/cm/topologymanager/topology_manager.go index b2bf858def6..71787a25732 100644 --- a/pkg/kubelet/cm/topologymanager/topology_manager.go +++ b/pkg/kubelet/cm/topologymanager/topology_manager.go @@ -212,7 +212,6 @@ func (m *manager) RemoveContainer(containerID string) error { } func (m *manager) Admit(attrs *lifecycle.PodAdmitAttributes) lifecycle.PodAdmitResult { - klog.InfoS("Topology Admit Handler", "podUID", attrs.Pod.UID, "podNamespace", attrs.Pod.Namespace, "podName", attrs.Pod.Name) metrics.TopologyManagerAdmissionRequestsTotal.Inc() startTime := time.Now() diff --git a/pkg/kubelet/eviction/eviction_manager.go b/pkg/kubelet/eviction/eviction_manager.go index a94d87bac07..3aa0023b837 100644 --- a/pkg/kubelet/eviction/eviction_manager.go +++ b/pkg/kubelet/eviction/eviction_manager.go @@ -172,8 +172,6 @@ func (m *managerImpl) Admit(attrs *lifecycle.PodAdmitAttributes) lifecycle.PodAd } } - // reject pods when under memory pressure (if pod is best effort), or if under disk pressure. - klog.InfoS("Failed to admit pod to node", "pod", klog.KObj(attrs.Pod), "nodeCondition", m.nodeConditions) return lifecycle.PodAdmitResult{ Admit: false, Reason: Reason, diff --git a/pkg/kubelet/kubelet.go b/pkg/kubelet/kubelet.go index b3a139c41f8..8ecf5b9fae8 100644 --- a/pkg/kubelet/kubelet.go +++ b/pkg/kubelet/kubelet.go @@ -2325,6 +2325,9 @@ func (kl *Kubelet) canAdmitPod(pods []*v1.Pod, pod *v1.Pod) (bool, string, strin } for _, podAdmitHandler := range kl.admitHandlers { if result := podAdmitHandler.Admit(attrs); !result.Admit { + + klog.InfoS("Pod admission denied", "podUID", attrs.Pod.UID, "pod", klog.KObj(attrs.Pod), "reason", result.Reason, "message", result.Message) + return false, result.Reason, result.Message } }