From e8efc51c1cb08543f1b005a2dfd6512a91491921 Mon Sep 17 00:00:00 2001 From: Damien Mathieu <42@dmathieu.com> Date: Mon, 19 Mar 2018 19:21:56 +0100 Subject: [PATCH] remove todo suggesting to add the cronjob start time --- pkg/controller/cronjob/utils.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/pkg/controller/cronjob/utils.go b/pkg/controller/cronjob/utils.go index 39b1101cef6..8947b83b966 100644 --- a/pkg/controller/cronjob/utils.go +++ b/pkg/controller/cronjob/utils.go @@ -171,8 +171,6 @@ func getRecentUnmetScheduleTimes(sj batchv1beta1.CronJob, now time.Time) ([]time // getJobFromTemplate makes a Job from a CronJob func getJobFromTemplate(sj *batchv1beta1.CronJob, scheduledTime time.Time) (*batchv1.Job, error) { - // TODO: consider adding the following labels: - // nominal-start-time=$RFC_3339_DATE_OF_INTENDED_START -- for user convenience labels := copyLabels(&sj.Spec.JobTemplate) annotations := copyAnnotations(&sj.Spec.JobTemplate) // We want job names for a given nominal start time to have a deterministic name to avoid the same job being created twice