From a82749999ddb195e32f37ba03b9e54a3778ec3cd Mon Sep 17 00:00:00 2001 From: PingWang Date: Tue, 16 Apr 2019 17:57:22 +0800 Subject: [PATCH] Delete unused struct, nodeEnumerator Signed-off-by: PingWang --- pkg/scheduler/factory/factory.go | 18 ------------------ pkg/scheduler/factory/factory_test.go | 26 -------------------------- 2 files changed, 44 deletions(-) diff --git a/pkg/scheduler/factory/factory.go b/pkg/scheduler/factory/factory.go index da07ef327ac..6ba88d44e4f 100644 --- a/pkg/scheduler/factory/factory.go +++ b/pkg/scheduler/factory/factory.go @@ -707,24 +707,6 @@ func MakeDefaultErrorFunc(client clientset.Interface, backoff *internalqueue.Pod } } -// nodeEnumerator allows a cache.Poller to enumerate items in a v1.NodeList -type nodeEnumerator struct { - *v1.NodeList -} - -// Len returns the number of items in the node list. -func (ne *nodeEnumerator) Len() int { - if ne.NodeList == nil { - return 0 - } - return len(ne.Items) -} - -// Get returns the item (and ID) with the particular index. -func (ne *nodeEnumerator) Get(index int) interface{} { - return &ne.Items[index] -} - type binder struct { Client clientset.Interface } diff --git a/pkg/scheduler/factory/factory_test.go b/pkg/scheduler/factory/factory_test.go index 7a263d3e9e5..05feed1c7aa 100644 --- a/pkg/scheduler/factory/factory_test.go +++ b/pkg/scheduler/factory/factory_test.go @@ -296,32 +296,6 @@ func TestDefaultErrorFunc(t *testing.T) { } } -func TestNodeEnumerator(t *testing.T) { - testList := &v1.NodeList{ - Items: []v1.Node{ - {ObjectMeta: metav1.ObjectMeta{Name: "foo"}}, - {ObjectMeta: metav1.ObjectMeta{Name: "bar"}}, - {ObjectMeta: metav1.ObjectMeta{Name: "baz"}}, - }, - } - me := nodeEnumerator{testList} - - if e, a := 3, me.Len(); e != a { - t.Fatalf("expected %v, got %v", e, a) - } - for i := range testList.Items { - t.Run(fmt.Sprintf("node enumerator/%v", i), func(t *testing.T) { - gotObj := me.Get(i) - if e, a := testList.Items[i].Name, gotObj.(*v1.Node).Name; e != a { - t.Errorf("Expected %v, got %v", e, a) - } - if e, a := &testList.Items[i], gotObj; !reflect.DeepEqual(e, a) { - t.Errorf("Expected %#v, got %v#", e, a) - } - }) - } -} - func TestBind(t *testing.T) { table := []struct { name string