github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-15 06:43:54 +00:00
Code Issues Projects Releases Wiki Activity

optimize the comment

Browse Source 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
This commit is contained in:
Ziqi Zhao 2023-12-05 22:46:27 +08:00
parent 51495bb4c5
commit e92501b8fc
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/kubelet/kubelet.go
View File

@ -1956,10 +1956,11 @@ func (kl *Kubelet) SyncPod(ctx context.Context, updateType kubetypes.SyncPodType
} }
} }
// TODO(#113606): connect this with the incoming context parameter, which comes from the pod worker. // TODO(#113606): use cancellation from the incoming context parameter, which comes from the pod worker.
// Currently, using that context causes test failures. To remove this todoCtx, any wait.Interrupted // Currently, using cancellation from that context causes test failures. To remove this WithoutCancel,
// errors need to be filtered from result and bypass the reasonCache - cancelling the context for // any wait.Interrupted errors need to be filtered from result and bypass the reasonCache - cancelling
// SyncPod is a known and deliberate error, not a generic error. // the context for SyncPod is a known and deliberate error, not a generic error.
// Use WithoutCancel instead of a new context.TODO() to propagate trace context
// Call the container runtime's SyncPod callback // Call the container runtime's SyncPod callback
sctx := context.WithoutCancel(ctx) sctx := context.WithoutCancel(ctx)
result := kl.containerRuntime.SyncPod(sctx, pod, podStatus, pullSecrets, kl.backOff) result := kl.containerRuntime.SyncPod(sctx, pod, podStatus, pullSecrets, kl.backOff)