e2e: restore volume lifecycle check for most tests

f1e1f3a416
disable the check to work around an issue in one test. It's better to keep the
check enabled by default and only disable it for that test.
This commit is contained in:
Patrick Ohly 2021-09-09 10:29:37 +02:00
parent 95390e6476
commit e99b945b17

View File

@ -235,14 +235,24 @@ func (h *hostpathCSIDriver) PrepareTest(f *framework.Framework) (*storageframewo
// testsuites/volumelimits.go `should support volume limits`
// test.
"--maxvolumespernode=10",
// Disable volume lifecycle checks due to issue #103651
// TODO: enable this check once issue is resolved for csi-host-path driver.
"--check-volume-lifecycle=false",
// Enable volume lifecycle checks, to report failure if
// the volume is not unpublished / unstaged correctly.
"--check-volume-lifecycle=true",
},
ProvisionerContainerName: "csi-provisioner",
SnapshotterContainerName: "csi-snapshotter",
NodeName: node.Name,
}
// Disable volume lifecycle checks due to issue #103651 for the one
// test that it breaks.
// TODO: enable this check once issue is resolved for csi-host-path driver
// (https://github.com/kubernetes/kubernetes/pull/104858).
if strings.Contains(ginkgo.CurrentGinkgoTestDescription().FullTestText,
"should unmount if pod is gracefully deleted while kubelet is down") {
o.DriverContainerArguments = append(o.DriverContainerArguments, "--check-volume-lifecycle=false")
}
cleanup, err := utils.CreateFromManifests(config.Framework, driverNamespace, func(item interface{}) error {
if err := utils.PatchCSIDeployment(config.Framework, o, item); err != nil {
return err