From e9b0454a9df1d4a889a168b623abcfadbf3d6d47 Mon Sep 17 00:00:00 2001 From: Ke Zhang Date: Wed, 3 Aug 2016 13:19:22 +0800 Subject: [PATCH] optimize lock of runtimeState stuct --- pkg/kubelet/runtime.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/kubelet/runtime.go b/pkg/kubelet/runtime.go index 0f1acbf47c2..90a83898a31 100644 --- a/pkg/kubelet/runtime.go +++ b/pkg/kubelet/runtime.go @@ -23,7 +23,7 @@ import ( ) type runtimeState struct { - sync.Mutex + sync.RWMutex lastBaseRuntimeSync time.Time baseRuntimeSyncThreshold time.Duration networkError error @@ -57,8 +57,8 @@ func (s *runtimeState) setPodCIDR(cidr string) { } func (s *runtimeState) podCIDR() string { - s.Lock() - defer s.Unlock() + s.RLock() + defer s.RUnlock() return s.cidr } @@ -69,8 +69,8 @@ func (s *runtimeState) setInitError(err error) { } func (s *runtimeState) errors() []string { - s.Lock() - defer s.Unlock() + s.RLock() + defer s.RUnlock() var ret []string if s.initError != nil { ret = append(ret, s.initError.Error())