github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 13:37:30 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #73672 from WanLinghao/failure_domain_remove

Browse Source 
Remove dead code about failure-domains option in kube-scheduler
This commit is contained in:
Kubernetes Prow Robot 2019-03-30 18:22:33 -07:00 committed by GitHub
commit e9c42a15f7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/kube-scheduler/app/options/deprecated.go
View File

@ -65,8 +65,6 @@ func (o *DeprecatedOptions) AddFlags(fs *pflag.FlagSet, cfg *kubeschedulerconfig
"RequiredDuringScheduling affinity is not symmetric, but there is an implicit PreferredDuringScheduling affinity rule corresponding "+ "RequiredDuringScheduling affinity is not symmetric, but there is an implicit PreferredDuringScheduling affinity rule corresponding "+
"to every RequiredDuringScheduling affinity rule. --hard-pod-affinity-symmetric-weight represents the weight of implicit PreferredDuringScheduling affinity rule. Must be in the range 0-100.") "to every RequiredDuringScheduling affinity rule. --hard-pod-affinity-symmetric-weight represents the weight of implicit PreferredDuringScheduling affinity rule. Must be in the range 0-100.")
fs.MarkDeprecated("hard-pod-affinity-symmetric-weight", "This option was moved to the policy configuration file") fs.MarkDeprecated("hard-pod-affinity-symmetric-weight", "This option was moved to the policy configuration file")
fs.StringVar(&cfg.FailureDomains, "failure-domains", cfg.FailureDomains, "Indicate the \"all topologies\" set for an empty topologyKey when it's used for PreferredDuringScheduling pod anti-affinity.")
fs.MarkDeprecated("failure-domains", "Doesn't have any effect. Will be removed in future version.")
} }
// Validate validates the deprecated scheduler options. // Validate validates the deprecated scheduler options.

2
cmd/kube-scheduler/app/options/options_test.go
View File

@ -206,7 +206,6 @@ users:
HardPodAffinitySymmetricWeight: 1, HardPodAffinitySymmetricWeight: 1,
HealthzBindAddress: "0.0.0.0:10251", HealthzBindAddress: "0.0.0.0:10251",
MetricsBindAddress: "0.0.0.0:10251", MetricsBindAddress: "0.0.0.0:10251",
FailureDomains: "kubernetes.io/hostname,failure-domain.beta.kubernetes.io/zone,failure-domain.beta.kubernetes.io/region",
LeaderElection: kubeschedulerconfig.KubeSchedulerLeaderElectionConfiguration{ LeaderElection: kubeschedulerconfig.KubeSchedulerLeaderElectionConfiguration{
LeaderElectionConfiguration: componentbaseconfig.LeaderElectionConfiguration{ LeaderElectionConfiguration: componentbaseconfig.LeaderElectionConfiguration{
LeaderElect: true, LeaderElect: true,
@ -286,7 +285,6 @@ users:
HardPodAffinitySymmetricWeight: 1, HardPodAffinitySymmetricWeight: 1,
HealthzBindAddress: "", // defaults empty when not running from config file HealthzBindAddress: "", // defaults empty when not running from config file
MetricsBindAddress: "", // defaults empty when not running from config file MetricsBindAddress: "", // defaults empty when not running from config file
FailureDomains: "kubernetes.io/hostname,failure-domain.beta.kubernetes.io/zone,failure-domain.beta.kubernetes.io/region",
LeaderElection: kubeschedulerconfig.KubeSchedulerLeaderElectionConfiguration{ LeaderElection: kubeschedulerconfig.KubeSchedulerLeaderElectionConfiguration{
LeaderElectionConfiguration: componentbaseconfig.LeaderElectionConfiguration{ LeaderElectionConfiguration: componentbaseconfig.LeaderElectionConfiguration{
LeaderElect: true, LeaderElect: true,

4
pkg/scheduler/apis/config/types.go
View File

@ -82,10 +82,6 @@ type KubeSchedulerConfiguration struct {
// nodes will be scored. // nodes will be scored.
PercentageOfNodesToScore int32 PercentageOfNodesToScore int32
// DEPRECATED.
// Indicate the "all topologies" set for empty topologyKey when it's used for PreferredDuringScheduling pod anti-affinity.
FailureDomains string
// Duration to wait for a binding operation to complete before timing out // Duration to wait for a binding operation to complete before timing out
// Value must be non-negative integer. The value zero indicates no waiting. // Value must be non-negative integer. The value zero indicates no waiting.
// If this value is nil, the default value will be used. // If this value is nil, the default value will be used.

4
pkg/scheduler/apis/config/v1alpha1/defaults.go
View File

@ -85,10 +85,6 @@ func SetDefaults_KubeSchedulerConfiguration(obj *kubescedulerconfigv1alpha1.Kube
obj.LeaderElection.LockObjectName = kubescedulerconfigv1alpha1.SchedulerDefaultLockObjectName obj.LeaderElection.LockObjectName = kubescedulerconfigv1alpha1.SchedulerDefaultLockObjectName
} }
if len(obj.FailureDomains) == 0 {
obj.FailureDomains = defaultFailureDomains
}
if len(obj.ClientConnection.ContentType) == 0 { if len(obj.ClientConnection.ContentType) == 0 {
obj.ClientConnection.ContentType = "application/vnd.kubernetes.protobuf" obj.ClientConnection.ContentType = "application/vnd.kubernetes.protobuf"
} }

2
pkg/scheduler/apis/config/v1alpha1/zz_generated.conversion.go generated
View File

@ -119,7 +119,6 @@ func autoConvert_v1alpha1_KubeSchedulerConfiguration_To_config_KubeSchedulerConf
} }
out.DisablePreemption = in.DisablePreemption out.DisablePreemption = in.DisablePreemption
out.PercentageOfNodesToScore = in.PercentageOfNodesToScore out.PercentageOfNodesToScore = in.PercentageOfNodesToScore
out.FailureDomains = in.FailureDomains
out.BindTimeoutSeconds = (*int64)(unsafe.Pointer(in.BindTimeoutSeconds)) out.BindTimeoutSeconds = (*int64)(unsafe.Pointer(in.BindTimeoutSeconds))
return nil return nil
} }
@ -148,7 +147,6 @@ func autoConvert_config_KubeSchedulerConfiguration_To_v1alpha1_KubeSchedulerConf
} }
out.DisablePreemption = in.DisablePreemption out.DisablePreemption = in.DisablePreemption
out.PercentageOfNodesToScore = in.PercentageOfNodesToScore out.PercentageOfNodesToScore = in.PercentageOfNodesToScore
out.FailureDomains = in.FailureDomains
out.BindTimeoutSeconds = (*int64)(unsafe.Pointer(in.BindTimeoutSeconds)) out.BindTimeoutSeconds = (*int64)(unsafe.Pointer(in.BindTimeoutSeconds))
return nil return nil
} }

4
staging/src/k8s.io/kube-scheduler/config/v1alpha1/types.go
View File

@ -78,10 +78,6 @@ type KubeSchedulerConfiguration struct {
// nodes will be scored. // nodes will be scored.
PercentageOfNodesToScore int32 `json:"percentageOfNodesToScore"` PercentageOfNodesToScore int32 `json:"percentageOfNodesToScore"`
// DEPRECATED.
// Indicate the "all topologies" set for empty topologyKey when it's used for PreferredDuringScheduling pod anti-affinity.
FailureDomains string `json:"failureDomains"`
// Duration to wait for a binding operation to complete before timing out // Duration to wait for a binding operation to complete before timing out
// Value must be non-negative integer. The value zero indicates no waiting. // Value must be non-negative integer. The value zero indicates no waiting.
// If this value is nil, the default value will be used. // If this value is nil, the default value will be used.