From e9fc6c28a202ded0228e8505f5e14f5ec2049a3d Mon Sep 17 00:00:00 2001 From: Alexander Zielenski Date: Mon, 28 Mar 2022 18:40:34 -0700 Subject: [PATCH] adjust comments --- .../k8s.io/client-go/discovery/cached/disk/cached_discovery.go | 2 +- staging/src/k8s.io/client-go/discovery/fake/discovery.go | 2 +- staging/src/k8s.io/client-go/openapi/groupversion.go | 2 -- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/staging/src/k8s.io/client-go/discovery/cached/disk/cached_discovery.go b/staging/src/k8s.io/client-go/discovery/cached/disk/cached_discovery.go index 004f00a567d..d3082d1e130 100644 --- a/staging/src/k8s.io/client-go/discovery/cached/disk/cached_discovery.go +++ b/staging/src/k8s.io/client-go/discovery/cached/disk/cached_discovery.go @@ -59,7 +59,7 @@ type CachedDiscoveryClient struct { // fresh is true if all used cache files were ours fresh bool - /// + // caching openapi v3 client which wraps the delegate's client openapiClient openapi.Client } diff --git a/staging/src/k8s.io/client-go/discovery/fake/discovery.go b/staging/src/k8s.io/client-go/discovery/fake/discovery.go index 1ec4354e494..2eef5365d53 100644 --- a/staging/src/k8s.io/client-go/discovery/fake/discovery.go +++ b/staging/src/k8s.io/client-go/discovery/fake/discovery.go @@ -156,7 +156,7 @@ func (c *FakeDiscovery) OpenAPISchema() (*openapi_v2.Document, error) { } func (c *FakeDiscovery) OpenAPIV3() openapi.Client { - panic("implement me") + panic("unimplemented") } // RESTClient returns a RESTClient that is used to communicate with API server diff --git a/staging/src/k8s.io/client-go/openapi/groupversion.go b/staging/src/k8s.io/client-go/openapi/groupversion.go index c636ca3c6d5..7c35833b483 100644 --- a/staging/src/k8s.io/client-go/openapi/groupversion.go +++ b/staging/src/k8s.io/client-go/openapi/groupversion.go @@ -40,8 +40,6 @@ func newGroupVersion(client *client, item handler3.OpenAPIV3DiscoveryGroupVersio } func (g *groupversion) Schema() (*openapi_v3.Document, error) { - // Check if this GVK is in the discovery map, if it is not, then it is not - // available. No point making the request. data, err := g.client.restClient.Get(). RequestURI(g.item.ServerRelativeURL). SetHeader("Accept", openAPIV3mimePb).