github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-28 05:57:25 +00:00
Code Issues Projects Releases Wiki Activity

kubectl: run - remove unneeded vars

Browse Source 
No need extra vars just for a single validation.

Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
This commit is contained in:
Douglas Schilling Landgraf 2021-01-15 21:03:27 -05:00
parent d73693cb44
commit ea017e53af
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
staging/src/k8s.io/kubectl/pkg/cmd/run/run.go
View File

@ -273,13 +273,12 @@ func (o *RunOptions) Run(f cmdutil.Factory, cmd *cobra.Command, args []string) e
} }
// validate image name // validate image name
imageName := o.Image if o.Image == "" {
if imageName == "" {
return fmt.Errorf("--image is required") return fmt.Errorf("--image is required")
} }
validImageRef := reference.ReferenceRegexp.MatchString(imageName)
if !validImageRef { if !reference.ReferenceRegexp.MatchString(o.Image) {
return fmt.Errorf("Invalid image name %q: %v", imageName, reference.ErrReferenceInvalidFormat) return fmt.Errorf("Invalid image name %q: %v", o.Image, reference.ErrReferenceInvalidFormat)
} }
if o.TTY && !o.Interactive { if o.TTY && !o.Interactive {