mirror of
https://github.com/k3s-io/kubernetes.git
synced 2026-01-06 07:57:35 +00:00
Merge pull request #31276 from juanvallejo/jvallejo_update-dry-run-create
Automatic merge from submit-queue Update kubectl create message when using --dry-run `kubectl create <resource> <name> --dry-run` provides a misleading success message. When commands such as `kubectl new-app node` are run with a `--dry-run` flag, they make this clear by appending a "(DRY RUN)" string to the final output. `kubectl create <resource> <name> --dry-run` does not do this, providing a potentially misleading output. This patch appends a "(DRY RUN)" string to the end of a successful message of `kubectl create` subcommands that support the `--dry-run` flag. `kubectl create quota quota --dry-run` ``` resourcequota "quota" created ``` `kubectl create quota quota --dry-run` ``` resourcequota "quota" created (DRY RUN) ``` **Release note**: ```release-note release-note-none ```
This commit is contained in:
@@ -388,7 +388,7 @@ func RunRollingUpdate(f *cmdutil.Factory, out io.Writer, cmd *cobra.Command, arg
|
||||
return err
|
||||
}
|
||||
_, res := meta.KindToResource(kinds[0])
|
||||
cmdutil.PrintSuccess(mapper, false, out, res.Resource, oldName, message)
|
||||
cmdutil.PrintSuccess(mapper, false, out, res.Resource, oldName, dryrun, message)
|
||||
return nil
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user