From 936ae632a0b6e1a83f1729aeff736baebbc4e68c Mon Sep 17 00:00:00 2001 From: Ted Yu Date: Tue, 24 Sep 2019 10:47:34 -0700 Subject: [PATCH] Remove unnecessary traversal of pod.Status.Conditions --- .../src/k8s.io/kubectl/pkg/util/podutils/podutils.go | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/staging/src/k8s.io/kubectl/pkg/util/podutils/podutils.go b/staging/src/k8s.io/kubectl/pkg/util/podutils/podutils.go index 142b8879651..847eb7e88b4 100644 --- a/staging/src/k8s.io/kubectl/pkg/util/podutils/podutils.go +++ b/staging/src/k8s.io/kubectl/pkg/util/podutils/podutils.go @@ -170,12 +170,10 @@ func afterOrZero(t1, t2 *metav1.Time) bool { } func podReadyTime(pod *corev1.Pod) *metav1.Time { - if IsPodReady(pod) { - for _, c := range pod.Status.Conditions { - // we only care about pod ready conditions - if c.Type == corev1.PodReady && c.Status == corev1.ConditionTrue { - return &c.LastTransitionTime - } + for _, c := range pod.Status.Conditions { + // we only care about pod ready conditions + if c.Type == corev1.PodReady && c.Status == corev1.ConditionTrue { + return &c.LastTransitionTime } } return &metav1.Time{}