From eaba1703b1bf14ad778b1567f5577258f0a0d7c9 Mon Sep 17 00:00:00 2001 From: lowang_bh Date: Sun, 16 Apr 2023 08:52:09 +0800 Subject: [PATCH] enhancemanet: reduce calculation calls Signed-off-by: lowang_bh --- pkg/scheduler/util/utils.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/scheduler/util/utils.go b/pkg/scheduler/util/utils.go index 3b083878b41..a477742032d 100644 --- a/pkg/scheduler/util/utils.go +++ b/pkg/scheduler/util/utils.go @@ -67,12 +67,12 @@ func GetEarliestPodStartTime(victims *extenderv1.Victims) *metav1.Time { maxPriority := corev1helpers.PodPriority(victims.Pods[0]) for _, pod := range victims.Pods { - if corev1helpers.PodPriority(pod) == maxPriority { - if GetPodStartTime(pod).Before(earliestPodStartTime) { - earliestPodStartTime = GetPodStartTime(pod) + if podPriority := corev1helpers.PodPriority(pod); podPriority == maxPriority { + if podStartTime := GetPodStartTime(pod); podStartTime.Before(earliestPodStartTime) { + earliestPodStartTime = podStartTime } - } else if corev1helpers.PodPriority(pod) > maxPriority { - maxPriority = corev1helpers.PodPriority(pod) + } else if podPriority > maxPriority { + maxPriority = podPriority earliestPodStartTime = GetPodStartTime(pod) } }