From 4af97e599a0876848832584177fcb4365f0b3fa2 Mon Sep 17 00:00:00 2001
From: Maciej Szulik <maszulik@redhat.com>
Date: Wed, 12 Oct 2022 15:33:41 +0200
Subject: [PATCH] Promote cronjob_job_creation_skew metric to stable

---
 pkg/controller/cronjob/metrics/metrics.go       |  4 ++--
 .../testdata/stable-metrics-list.yaml           | 17 +++++++++++++++++
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/pkg/controller/cronjob/metrics/metrics.go b/pkg/controller/cronjob/metrics/metrics.go
index ca62808e90e..d9dd08c97b8 100644
--- a/pkg/controller/cronjob/metrics/metrics.go
+++ b/pkg/controller/cronjob/metrics/metrics.go
@@ -29,9 +29,9 @@ var (
 	CronJobCreationSkew = metrics.NewHistogram(
 		&metrics.HistogramOpts{
 			Subsystem:      CronJobControllerSubsystem,
-			Name:           "cronjob_job_creation_skew_duration_seconds",
+			Name:           "job_creation_skew_duration_seconds",
 			Help:           "Time between when a cronjob is scheduled to be run, and when the corresponding job is created",
-			StabilityLevel: metrics.ALPHA,
+			StabilityLevel: metrics.STABLE,
 			Buckets:        metrics.ExponentialBuckets(1, 2, 10),
 		},
 	)
diff --git a/test/instrumentation/testdata/stable-metrics-list.yaml b/test/instrumentation/testdata/stable-metrics-list.yaml
index 5c6b551ce6c..590b81ce802 100644
--- a/test/instrumentation/testdata/stable-metrics-list.yaml
+++ b/test/instrumentation/testdata/stable-metrics-list.yaml
@@ -1,3 +1,20 @@
+- name: job_creation_skew_duration_seconds
+  subsystem: cronjob_controller
+  help: Time between when a cronjob is scheduled to be run, and when the corresponding
+    job is created
+  type: Histogram
+  stabilityLevel: STABLE
+  buckets:
+  - 1
+  - 2
+  - 4
+  - 8
+  - 16
+  - 32
+  - 64
+  - 128
+  - 256
+  - 512
 - name: evictions_total
   subsystem: node_collector
   help: Number of Node evictions that happened since current instance of NodeController