From eb688e098f5abd095584d84a50dba1beeea97db5 Mon Sep 17 00:00:00 2001 From: mattjmcnaughton Date: Fri, 5 Jan 2018 08:40:24 -0500 Subject: [PATCH] Add RESTClient Custom metrics empty test Add testing for a previously untested path, which is tested when getting resource metrics. --- .../podautoscaler/metrics/rest_metrics_client_test.go | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/pkg/controller/podautoscaler/metrics/rest_metrics_client_test.go b/pkg/controller/podautoscaler/metrics/rest_metrics_client_test.go index 289b93f04d7..e51c5309f8c 100644 --- a/pkg/controller/podautoscaler/metrics/rest_metrics_client_test.go +++ b/pkg/controller/podautoscaler/metrics/rest_metrics_client_test.go @@ -249,6 +249,16 @@ func TestRESTClientQpsSumEqualZero(t *testing.T) { tc.runTest(t) } +func TestRESTClientQpsEmptyMetrics(t *testing.T) { + tc := restClientTestCase{ + metricName: "qps", + desiredError: fmt.Errorf("no metrics returned from custom metrics API"), + reportedMetricPoints: []metricPoint{}, + } + + tc.runTest(t) +} + func TestRESTClientCPUEmptyMetrics(t *testing.T) { tc := restClientTestCase{ resourceName: v1.ResourceCPU,