github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-01 15:58:37 +00:00
Code Issues Projects Releases Wiki Activity

fixtodo:generate an event for a missed starting window

Browse Source
This commit is contained in:
hangaoshuai 2018-04-04 09:26:08 +08:00
parent d3bed1e5c9
commit eb75a3303a
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/controller/cronjob/cronjob_controller.go
View File

@ -273,9 +273,8 @@ func syncOne(sj *batchv1beta1.CronJob, js []batchv1.Job, now time.Time, jc jobCo
} }
if tooLate { if tooLate {
glog.V(4).Infof("Missed starting window for %s", nameForLog) glog.V(4).Infof("Missed starting window for %s", nameForLog)
// TODO: generate an event for a miss. Use a warning level event because it indicates a recorder.Eventf(sj, v1.EventTypeWarning, "MissSchedule", "Missed scheduled time to start a job: %s", scheduledTime.Format(time.RFC1123Z))
// problem with the controller (restart or long queue), and is not expected by user either. // TODO: Since we don't set LastScheduleTime when not scheduling, we are going to keep noticing
// Since we don't set LastScheduleTime when not scheduling, we are going to keep noticing
// the miss every cycle. In order to avoid sending multiple events, and to avoid processing // the miss every cycle. In order to avoid sending multiple events, and to avoid processing
// the sj again and again, we could set a Status.LastMissedTime when we notice a miss. // the sj again and again, we could set a Status.LastMissedTime when we notice a miss.
// Then, when we call getRecentUnmetScheduleTimes, we can take max(creationTimestamp, // Then, when we call getRecentUnmetScheduleTimes, we can take max(creationTimestamp,