From eb8f3240b0b4563e73a9284800e4c3391db22def Mon Sep 17 00:00:00 2001 From: Fabio Rapposelli Date: Wed, 20 Feb 2019 14:12:05 +0100 Subject: [PATCH] do not return error on invalid mac address in vsphere cloud provider --- pkg/cloudprovider/providers/vsphere/vsphere.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/cloudprovider/providers/vsphere/vsphere.go b/pkg/cloudprovider/providers/vsphere/vsphere.go index 55175bf1202..b8aa2ea8de3 100644 --- a/pkg/cloudprovider/providers/vsphere/vsphere.go +++ b/pkg/cloudprovider/providers/vsphere/vsphere.go @@ -569,7 +569,8 @@ func getLocalIP() ([]v1.NodeAddress, error) { vmMACAddr := strings.ToLower(i.HardwareAddr.String()) // Making sure that the MAC address is long enough if len(vmMACAddr) < 17 { - return addrs, fmt.Errorf("MAC address %q is invalid", vmMACAddr) + klog.V(4).Infof("Skipping invalid MAC address: %q", vmMACAddr) + continue } if vmwareOUI[vmMACAddr[:8]] { nodehelpers.AddToNodeAddresses(&addrs,