From 773dbde0cf7ceb3d5e041a549d051eea86353092 Mon Sep 17 00:00:00 2001 From: Michael Taufen Date: Tue, 29 Nov 2016 21:45:05 -0800 Subject: [PATCH] Collect logs for dead kubelets too Collect logs via journalctl if journalctl is installed, rather than only if kubelet.service is running. The old way resulted in us losing logs any time the kubelet was failing. This, of course, breaks on a node if someone decided to install journalctl but not use it. But that is not the case on any of the images used by cluster-level tests at present. --- cluster/log-dump.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cluster/log-dump.sh b/cluster/log-dump.sh index 7096bad7a73..4b3e62f4f6e 100755 --- a/cluster/log-dump.sh +++ b/cluster/log-dump.sh @@ -131,7 +131,7 @@ function save-logs() { esac fi - if log-dump-ssh "${node_name}" "sudo systemctl status kubelet.service" &> /dev/null; then + if log-dump-ssh "${node_name}" "command -v journalctl" &> /dev/null; then log-dump-ssh "${node_name}" "sudo journalctl --output=short-precise -u kube-node-installation.service" > "${dir}/kube-node-installation.log" || true log-dump-ssh "${node_name}" "sudo journalctl --output=short-precise -u kube-node-configuration.service" > "${dir}/kube-node-configuration.log" || true log-dump-ssh "${node_name}" "sudo journalctl --output=cat -u kubelet.service" > "${dir}/kubelet.log" || true