From b70e1d836c2d438af6b01fd297677b900b364a33 Mon Sep 17 00:00:00 2001 From: knight42 Date: Sat, 5 Sep 2020 18:50:45 +0800 Subject: [PATCH] test(workqueue): deflake TestMetrics Signed-off-by: knight42 --- staging/src/k8s.io/client-go/util/workqueue/metrics_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/staging/src/k8s.io/client-go/util/workqueue/metrics_test.go b/staging/src/k8s.io/client-go/util/workqueue/metrics_test.go index 4848f68f240..e48cc38f53d 100644 --- a/staging/src/k8s.io/client-go/util/workqueue/metrics_test.go +++ b/staging/src/k8s.io/client-go/util/workqueue/metrics_test.go @@ -252,13 +252,17 @@ func TestMetrics(t *testing.T) { // use a channel to ensure we don't look at the metric before it's // been set. ch := make(chan struct{}, 1) + longestCh := make(chan struct{}, 1) mp.unfinished.notifyCh = ch + mp.longest.notifyCh = longestCh c.Step(time.Millisecond) <-ch mp.unfinished.notifyCh = nil if e, a := .001, mp.unfinished.gaugeValue(); e != a { t.Errorf("expected %v, got %v", e, a) } + <-longestCh + mp.longest.notifyCh = nil if e, a := .001, mp.longest.gaugeValue(); e != a { t.Errorf("expected %v, got %v", e, a) }