From ecad65a3f8622fdf1be556a6c1cd8e19007f3949 Mon Sep 17 00:00:00 2001 From: Pavithra Ramesh Date: Fri, 2 Aug 2019 11:24:24 -0700 Subject: [PATCH] Added comment after invoking ensureLoadBalancer --- pkg/controller/service/service_controller.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/controller/service/service_controller.go b/pkg/controller/service/service_controller.go index 95cc877fa7e..8fd896bfcc2 100644 --- a/pkg/controller/service/service_controller.go +++ b/pkg/controller/service/service_controller.go @@ -340,8 +340,10 @@ func (s *ServiceController) syncLoadBalancerIfNeeded(service *v1.Service, key st newStatus, err = s.ensureLoadBalancer(service) if err != nil { if err == cloudprovider.ImplementedElsewhere { - klog.V(4).Infof("LoadBalancer for service %s implemented by a different controller %s, Ignoring error", - key, s.cloud.ProviderName()) + // ImplementedElsewhere indicates that the ensureLoadBalancer is a nop and the + // functionality is implemented by a different controller. In this case, we + // return immediately without doing anything. + klog.V(4).Infof("LoadBalancer for service %s implemented by a different controller %s, Ignoring error", key, s.cloud.ProviderName()) return op, nil } return op, fmt.Errorf("failed to ensure load balancer: %v", err)