From ece3188507a49c1149bb0a6dadddc1ea01439e7d Mon Sep 17 00:00:00 2001 From: xilabao Date: Thu, 22 Jun 2017 17:48:54 +0800 Subject: [PATCH] remove dead code in rbac helper --- pkg/apis/rbac/helpers.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkg/apis/rbac/helpers.go b/pkg/apis/rbac/helpers.go index 5a246ab4509..549aedc98fc 100644 --- a/pkg/apis/rbac/helpers.go +++ b/pkg/apis/rbac/helpers.go @@ -215,9 +215,8 @@ func (r *PolicyRuleBuilder) Rule() (PolicyRule, error) { return PolicyRule{}, fmt.Errorf("non-resource rule may not have apiGroups, resources, or resourceNames: %#v", r.PolicyRule) } case len(r.PolicyRule.Resources) > 0: - if len(r.PolicyRule.NonResourceURLs) != 0 { - return PolicyRule{}, fmt.Errorf("resource rule may not have nonResourceURLs: %#v", r.PolicyRule) - } + // resource rule may not have nonResourceURLs + if len(r.PolicyRule.APIGroups) == 0 { // this a common bug return PolicyRule{}, fmt.Errorf("resource rule must have apiGroups: %#v", r.PolicyRule)