github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-10 04:27:54 +00:00
Code Issues Projects Releases Wiki Activity

kubelet/lifecycle handlers: refactor port resolver

Browse Source 
Changes the three test cases for port resolver test to a table test
instead.

Signed-off-by: Victor Palade <victor@cloudflavor.io>
This commit is contained in:
Victor Palade 2023-09-20 20:25:17 +02:00
parent 7dcb412675
commit ed76c371df
No known key found for this signature in database
GPG Key ID: 0D8D7122CCBC8B94
1 changed files with 36 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
pkg/kubelet/lifecycle/handlers_test.go
View File

@ -43,48 +43,44 @@ import (
"k8s.io/kubernetes/pkg/kubelet/util/format" "k8s.io/kubernetes/pkg/kubelet/util/format"
) )
func TestResolvePortInt(t *testing.T) { func TestResolvePort(t *testing.T) {
expected := 80 for _, testCase := range []struct {
port, err := resolvePort(intstr.FromInt32(int32(expected)), &v1.Container{}) container *v1.Container
if port != expected { stringPort string
t.Errorf("expected: %d, saw: %d", expected, port) expected int
} }{
if err != nil { {
t.Errorf("unexpected error: %v", err) stringPort: "foo",
} container: &v1.Container{
} Ports: []v1.ContainerPort{{Name: "foo", ContainerPort: int32(80)}},
},
func TestResolvePortString(t *testing.T) { expected: 80,
expected := 80
name := "foo"
container := &v1.Container{
Ports: []v1.ContainerPort{
{Name: name, ContainerPort: int32(expected)},
}, },
} {
port, err := resolvePort(intstr.FromString(name), container) container: &v1.Container{},
if port != expected { stringPort: "80",
t.Errorf("expected: %d, saw: %d", expected, port) expected: 80,
}
if err != nil {
t.Errorf("unexpected error: %v", err)
}
}
func TestResolvePortStringUnknown(t *testing.T) {
expected := int32(80)
name := "foo"
container := &v1.Container{
Ports: []v1.ContainerPort{
{Name: "bar", ContainerPort: expected},
}, },
} {
port, err := resolvePort(intstr.FromString(name), container) container: &v1.Container{
if port != -1 { Ports: []v1.ContainerPort{
t.Errorf("expected: -1, saw: %d", port) {Name: "bar", ContainerPort: int32(80)},
} },
if err == nil { },
t.Error("unexpected non-error") stringPort: "foo",
expected: -1,
},
} {
port, err := resolvePort(intstr.FromString(testCase.stringPort), testCase.container)
if testCase.expected != -1 && err != nil {
t.Fatalf("unexpected error while resolving port: %s", err)
}
if testCase.expected == -1 && err == nil {
t.Errorf("expected error when a port fails to resolve")
}
if testCase.expected != port {
t.Errorf("failed to resolve port, expected %d, got %d", testCase.expected, port)
}
} }
} }