diff --git a/staging/src/k8s.io/apiextensions-apiserver/test/integration/apiapproval_test.go b/staging/src/k8s.io/apiextensions-apiserver/test/integration/apiapproval_test.go index 558b0c66410..19e1cf7cdbd 100644 --- a/staging/src/k8s.io/apiextensions-apiserver/test/integration/apiapproval_test.go +++ b/staging/src/k8s.io/apiextensions-apiserver/test/integration/apiapproval_test.go @@ -73,9 +73,9 @@ func TestAPIApproval(t *testing.T) { t.Fatal(err) } err = wait.PollUntilContextTimeout(context.Background(), 100*time.Millisecond, 30*time.Second, true, func(ctx context.Context) (bool, error) { - approvedKubeAPI, err = apiExtensionClient.ApiextensionsV1().CustomResourceDefinitions().Get(ctx, approvedKubeAPI.Name, metav1.GetOptions{}) - if err != nil { - return false, err + approvedKubeAPI, getErr := apiExtensionClient.ApiextensionsV1().CustomResourceDefinitions().Get(ctx, approvedKubeAPI.Name, metav1.GetOptions{}) + if getErr != nil { + return false, getErr } if approvedKubeAPIApproved := findCRDCondition(approvedKubeAPI, apiextensionsv1.KubernetesAPIApprovalPolicyConformant); approvedKubeAPIApproved == nil || approvedKubeAPIApproved.Status != apiextensionsv1.ConditionTrue { t.Log(approvedKubeAPIApproved) diff --git a/staging/src/k8s.io/apiextensions-apiserver/test/integration/conversion/conversion_test.go b/staging/src/k8s.io/apiextensions-apiserver/test/integration/conversion/conversion_test.go index cf970fff1ba..9ea69931b82 100644 --- a/staging/src/k8s.io/apiextensions-apiserver/test/integration/conversion/conversion_test.go +++ b/staging/src/k8s.io/apiextensions-apiserver/test/integration/conversion/conversion_test.go @@ -220,12 +220,12 @@ func testWebhookConverter(t *testing.T, watchCache bool) { // wait until new webhook is called the first time if err := wait.PollUntilContextTimeout(context.Background(), time.Millisecond*100, wait.ForeverTestTimeout, true, func(ctx context.Context) (done bool, err error) { - _, err = ctc.versionedClient(marker.GetNamespace(), "v1alpha1").Get(ctx, marker.GetName(), metav1.GetOptions{}) + _, getErr := ctc.versionedClient(marker.GetNamespace(), "v1alpha1").Get(ctx, marker.GetName(), metav1.GetOptions{}) select { case <-upCh: return true, nil default: - t.Logf("Waiting for webhook to become effective, getting marker object: %v", err) + t.Logf("Waiting for webhook to become effective, getting marker object: %v", getErr) return false, nil } }); err != nil { diff --git a/staging/src/k8s.io/apiextensions-apiserver/test/integration/conversion/webhook.go b/staging/src/k8s.io/apiextensions-apiserver/test/integration/conversion/webhook.go index 6da7c438810..08cfdb9c2dc 100644 --- a/staging/src/k8s.io/apiextensions-apiserver/test/integration/conversion/webhook.go +++ b/staging/src/k8s.io/apiextensions-apiserver/test/integration/conversion/webhook.go @@ -65,8 +65,8 @@ func StartConversionWebhookServer(handler http.Handler) (func(), *apiextensionsv // StartTLS returns immediately, there is a small chance of a race to avoid. if err := wait.PollUntilContextTimeout(context.Background(), time.Millisecond*100, wait.ForeverTestTimeout, true, func(ctx context.Context) (done bool, err error) { - _, err = webhookServer.Client().Get(webhookServer.URL) // even a 404 is fine - return err == nil, nil + _, getErr := webhookServer.Client().Get(webhookServer.URL) // even a 404 is fine + return getErr == nil, nil }); err != nil { webhookServer.Close() return nil, nil, err diff --git a/staging/src/k8s.io/apiextensions-apiserver/test/integration/listtype_test.go b/staging/src/k8s.io/apiextensions-apiserver/test/integration/listtype_test.go index ddadc18ae42..2e4e6e64694 100644 --- a/staging/src/k8s.io/apiextensions-apiserver/test/integration/listtype_test.go +++ b/staging/src/k8s.io/apiextensions-apiserver/test/integration/listtype_test.go @@ -210,15 +210,15 @@ func TestListTypes(t *testing.T) { t.Logf("Updating again with invalid values, eventually successfully due to ratcheting logic") err = wait.PollUntilContextTimeout(context.Background(), time.Millisecond*100, wait.ForeverTestTimeout, true, func(ctx context.Context) (bool, error) { - _, err = fooClient.Update(ctx, modifiedInstance, metav1.UpdateOptions{}) - if err == nil { - return true, err + _, updateErr := fooClient.Update(ctx, modifiedInstance, metav1.UpdateOptions{}) + if updateErr == nil { + return true, nil } - if errors.IsInvalid(err) { + if errors.IsInvalid(updateErr) { // wait until modifiedInstance becomes valid again return false, nil } - return false, err + return false, updateErr }) if err != nil { t.Fatalf("unexpected error: %v", err) diff --git a/staging/src/k8s.io/apiextensions-apiserver/test/integration/validation_test.go b/staging/src/k8s.io/apiextensions-apiserver/test/integration/validation_test.go index 6812d53b471..5f593aae70b 100644 --- a/staging/src/k8s.io/apiextensions-apiserver/test/integration/validation_test.go +++ b/staging/src/k8s.io/apiextensions-apiserver/test/integration/validation_test.go @@ -779,14 +779,14 @@ func TestCRValidationOnCRDUpdate(t *testing.T) { // CR is now accepted err = wait.PollUntilContextTimeout(context.Background(), 500*time.Millisecond, wait.ForeverTestTimeout, true, func(ctx context.Context) (done bool, err error) { - _, err = noxuResourceClient.Create(ctx, instanceToCreate, metav1.CreateOptions{}) - if _, isStatus := err.(*apierrors.StatusError); isStatus { - if apierrors.IsInvalid(err) { + _, createErr := noxuResourceClient.Create(ctx, instanceToCreate, metav1.CreateOptions{}) + if _, isStatus := createErr.(*apierrors.StatusError); isStatus { + if apierrors.IsInvalid(createErr) { return false, nil } } - if err != nil { - return false, err + if createErr != nil { + return false, createErr } return true, nil }) diff --git a/staging/src/k8s.io/apiextensions-apiserver/test/integration/versioning_test.go b/staging/src/k8s.io/apiextensions-apiserver/test/integration/versioning_test.go index c46e5240d22..2bd46a80621 100644 --- a/staging/src/k8s.io/apiextensions-apiserver/test/integration/versioning_test.go +++ b/staging/src/k8s.io/apiextensions-apiserver/test/integration/versioning_test.go @@ -92,14 +92,14 @@ func TestInternalVersionIsHandlerVersion(t *testing.T) { patch := []byte(fmt.Sprintf(`{"i": %d}`, i)) i++ - _, err = noxuNamespacedResourceClientV1beta1.Patch(ctx, "foo", types.MergePatchType, patch, metav1.PatchOptions{}) - if err != nil { + _, patchErr := noxuNamespacedResourceClientV1beta1.Patch(ctx, "foo", types.MergePatchType, patch, metav1.PatchOptions{}) + if patchErr != nil { // work around "grpc: the client connection is closing" error // TODO: fix the grpc error - if err, ok := err.(*errors.StatusError); ok && err.Status().Code == http.StatusInternalServerError { + if statusErr, ok := patchErr.(*errors.StatusError); ok && statusErr.Status().Code == http.StatusInternalServerError { return false, nil } - return false, err + return false, patchErr } return true, nil }) @@ -115,16 +115,16 @@ func TestInternalVersionIsHandlerVersion(t *testing.T) { patch := []byte(fmt.Sprintf(`{"i": %d}`, i)) i++ - _, err = noxuNamespacedResourceClientV1beta2.Patch(ctx, "foo", types.MergePatchType, patch, metav1.PatchOptions{}) - assert.Error(t, err) + _, patchErr := noxuNamespacedResourceClientV1beta2.Patch(ctx, "foo", types.MergePatchType, patch, metav1.PatchOptions{}) + assert.Error(t, patchErr) // work around "grpc: the client connection is closing" error // TODO: fix the grpc error - if err, ok := err.(*errors.StatusError); ok && err.Status().Code == http.StatusInternalServerError { + if statusErr, ok := patchErr.(*errors.StatusError); ok && statusErr.Status().Code == http.StatusInternalServerError { return false, nil } - assert.ErrorContains(t, err, "apiVersion") + assert.ErrorContains(t, patchErr, "apiVersion") return true, nil }) assert.NoError(t, err)