From edb98fb493636a61935f7c78be4d505de59110b4 Mon Sep 17 00:00:00 2001 From: Stephen Augustus Date: Tue, 12 May 2020 04:26:16 -0400 Subject: [PATCH] verify: Exclude verify-external-dependencies from make verify Also adds verify-external-dependencies to QUICK_PATTERNS Signed-off-by: Stephen Augustus --- hack/make-rules/verify.sh | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hack/make-rules/verify.sh b/hack/make-rules/verify.sh index bb0b40bc3b2..b91244cb8fd 100755 --- a/hack/make-rules/verify.sh +++ b/hack/make-rules/verify.sh @@ -52,12 +52,14 @@ if [[ ${EXCLUDE_TYPECHECK:-} =~ ^[yY]$ ]]; then ) fi - -# Exclude vendor checks in certain cases, if they're running in a separate job. +# Exclude dependency checks in certain cases, if they're running in a separate job. +# From @cblecker: We can't change the variable name here, unless we update it throughout +# test-infra (and we would need to pick it backwards). if [[ ${EXCLUDE_GODEP:-} =~ ^[yY]$ ]]; then EXCLUDED_PATTERNS+=( - "verify-vendor.sh" # runs in separate godeps job - "verify-vendor-licenses.sh" # runs in separate godeps job + "verify-external-dependencies-version.sh" # runs in separate dependencies job + "verify-vendor.sh" # runs in separate dependencies job + "verify-vendor-licenses.sh" # runs in separate dependencies job ) fi @@ -75,6 +77,7 @@ QUICK_PATTERNS+=( "verify-api-groups.sh" "verify-bazel.sh" "verify-boilerplate.sh" + "verify-external-dependencies-version.sh" "verify-vendor-licenses.sh" "verify-gofmt.sh" "verify-imports.sh"