github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-09 12:07:47 +00:00
Code Issues Projects Releases Wiki Activity

add TODOs

Browse Source
This commit is contained in:
James DeFelice 2015-06-11 12:41:50 +00:00
parent f445ead2da
commit ee309f3cff
3 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/mesos/pkg/scheduler/constraint/doc.go
View File

@ -16,4 +16,6 @@ limitations under the License.
// Package constraint exposes Marathon-like constraints for scheduling pods. // Package constraint exposes Marathon-like constraints for scheduling pods.
// Incomplete. // Incomplete.
// TODO(jdef) We need better alignment between k8s-mesos and k8s scheduling
// constraints (read: a common constraints API).
package constraint package constraint

4
contrib/mesos/pkg/scheduler/plugin.go
View File

@ -326,6 +326,10 @@ func (k *kubeScheduler) doSchedule(task *podtask.T, err error) (string, error) {
return "", fmt.Errorf("task.offer assignment must be idempotent, task %+v: offer %+v", task, offer) return "", fmt.Errorf("task.offer assignment must be idempotent, task %+v: offer %+v", task, offer)
} }
task.Offer = offer task.Offer = offer
//TODO(jdef) FillFromDetails currently allocates fixed (hardwired) cpu and memory resources for all
//tasks. This will be fixed once we properly integrate parent-cgroup support into the kublet-executor.
//For now we are completely ignoring the resources specified in the pod.
//see: https://github.com/mesosphere/kubernetes-mesos/issues/68
task.FillFromDetails(details) task.FillFromDetails(details)
if err := k.api.tasks().Update(task); err != nil { if err := k.api.tasks().Update(task); err != nil {
offer.Release() offer.Release()

1
contrib/mesos/pkg/scheduler/podtask/pod_task.go
View File

@ -153,6 +153,7 @@ func (t *T) BuildTaskInfo() *mesos.TaskInfo {
// Fill the Spec in the T, should be called during k8s scheduling, // Fill the Spec in the T, should be called during k8s scheduling,
// before binding. // before binding.
// TODO(jdef): remove hardcoded values and make use of actual pod resource settings
func (t *T) FillFromDetails(details *mesos.Offer) error { func (t *T) FillFromDetails(details *mesos.Offer) error {
if details == nil { if details == nil {
//programming error //programming error