From ef2e5bb8ed1ba3e28c3d9b75fb923be64c9b5961 Mon Sep 17 00:00:00 2001 From: Abdullah Gharaibeh Date: Fri, 17 May 2019 10:48:43 -0400 Subject: [PATCH] Addressed reviewers comments. --- pkg/probe/http/http_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/probe/http/http_test.go b/pkg/probe/http/http_test.go index 062fe8f03e9..9f9afc30d6f 100644 --- a/pkg/probe/http/http_test.go +++ b/pkg/probe/http/http_test.go @@ -347,14 +347,16 @@ func TestHTTPProbeChecker_HostHeaderPreservedAfterRedirect(t *testing.T) { headers := http.Header{} headers.Add("Host", test.hostHeader) t.Run(desc+"local", func(t *testing.T) { - prober := New(false) + followNonLocalRedirects := false + prober := New(followNonLocalRedirects) target, err := url.Parse(server.URL + "/redirect") require.NoError(t, err) result, _, _ := prober.Probe(target, headers, wait.ForeverTestTimeout) assert.Equal(t, test.expectedResult, result) }) t.Run(desc+"nonlocal", func(t *testing.T) { - prober := New(true) + followNonLocalRedirects := true + prober := New(followNonLocalRedirects) target, err := url.Parse(server.URL + "/redirect") require.NoError(t, err) result, _, _ := prober.Probe(target, headers, wait.ForeverTestTimeout)