From ef3bf86f5b6caa52e57f9fd05748694ea94f5de1 Mon Sep 17 00:00:00 2001 From: Jordan Liggitt Date: Mon, 25 Oct 2021 13:27:18 -0400 Subject: [PATCH] PodSecurity: test: ensure fixtures are exercised for all relevant policy versions --- .../pod-security-admission/test/fixtures_test.go | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/staging/src/k8s.io/pod-security-admission/test/fixtures_test.go b/staging/src/k8s.io/pod-security-admission/test/fixtures_test.go index 0fbf5eda3a6..d7d70e829b5 100644 --- a/staging/src/k8s.io/pod-security-admission/test/fixtures_test.go +++ b/staging/src/k8s.io/pod-security-admission/test/fixtures_test.go @@ -46,9 +46,17 @@ func TestFixtures(t *testing.T) { defaultChecks := policy.DefaultChecks() + const newestMinorVersionToTest = 22 + + policyVersions := computeVersionsToTest(t, defaultChecks) + newestMinorVersionWithPolicyChanges := policyVersions[len(policyVersions)-1].Minor() + + if newestMinorVersionToTest < newestMinorVersionWithPolicyChanges { + t.Fatalf("fixtures only tested up to %d, but policy changes exist up to %d", newestMinorVersionToTest, newestMinorVersionWithPolicyChanges) + } + for _, level := range []api.Level{api.LevelBaseline, api.LevelRestricted} { - // TODO: derive from registered levels - for version := 0; version <= 22; version++ { + for version := 0; version <= newestMinorVersionToTest; version++ { passDir := filepath.Join("testdata", string(level), fmt.Sprintf("v1.%d", version), "pass") failDir := filepath.Join("testdata", string(level), fmt.Sprintf("v1.%d", version), "fail")