github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-04 18:00:08 +00:00
Code Issues Projects Releases Wiki Activity

Clean up the ugliest unit test ever

Browse Source 
This volume-validation test was a disaster.  Better now, if longer to
scroll-through.
This commit is contained in:
Tim Hockin 2016-07-29 23:52:25 -07:00
parent 54e92bbc49
commit ef4bccf63e
2 changed files with 936 additions and 265 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pkg/api/validation/validation.go
View File

@ -778,6 +778,7 @@ func validateLocalDescendingPath(targetPath string, fldPath *field.Path) field.E
for _, item := range parts { for _, item := range parts {
if item == ".." { if item == ".." {
allErrs = append(allErrs, field.Invalid(fldPath, targetPath, "must not contain '..'")) allErrs = append(allErrs, field.Invalid(fldPath, targetPath, "must not contain '..'"))
break // even for `../../..`, one error is sufficient to make the point
} }
} }
return allErrs return allErrs

1200
pkg/api/validation/validation_test.go
View File

File diff suppressed because it is too large Load Diff