github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 13:37:30 +00:00
Code Issues Projects Releases Wiki Activity

k8s.io/component-base: support GetCounterMetricValue for Counter

Browse Source 
GetCounterMetricValue has an unchecked conversion to metrics.Metric,
something that didn't work for a *Counter because it didn't implement
that interface.
This commit is contained in:
Patrick Ohly 2021-02-23 21:21:05 +01:00
parent 6cb28fd1b4
commit ef6f65bead
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
staging/src/k8s.io/component-base/metrics/counter.go
View File

@ -20,6 +20,7 @@ import (
"context" "context"
"github.com/blang/semver" "github.com/blang/semver"
"github.com/prometheus/client_golang/prometheus" "github.com/prometheus/client_golang/prometheus"
dto "github.com/prometheus/client_model/go"
) )
// Counter is our internal representation for our wrapping struct around prometheus // Counter is our internal representation for our wrapping struct around prometheus
@ -31,6 +32,9 @@ type Counter struct {
selfCollector selfCollector
} }
// The implementation of the Metric interface is expected by testutil.GetCounterMetricValue.
var _ Metric = &Counter{}
// NewCounter returns an object which satisfies the kubeCollector and CounterMetric interfaces. // NewCounter returns an object which satisfies the kubeCollector and CounterMetric interfaces.
// However, the object returned will not measure anything unless the collector is first // However, the object returned will not measure anything unless the collector is first
// registered, since the metric is lazily instantiated. // registered, since the metric is lazily instantiated.
@ -46,6 +50,14 @@ func NewCounter(opts *CounterOpts) *Counter {
return kc return kc
} }
func (c *Counter) Desc() *prometheus.Desc {
return c.metric.Desc()
}
func (c *Counter) Write(to *dto.Metric) error {
return c.metric.Write(to)
}
// Reset resets the underlying prometheus Counter to start counting from 0 again // Reset resets the underlying prometheus Counter to start counting from 0 again
func (c *Counter) Reset() { func (c *Counter) Reset() {
if !c.IsCreated() { if !c.IsCreated() {