From 831a8eed68bf96581f0b894e4a52d09b3a8d6239 Mon Sep 17 00:00:00 2001 From: Shubham Kuchhal Date: Tue, 25 Jan 2022 14:11:56 +0530 Subject: [PATCH 1/3] Added Logs Statement for a Pod in graph_populator. --- plugin/pkg/auth/authorizer/node/graph_populator.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugin/pkg/auth/authorizer/node/graph_populator.go b/plugin/pkg/auth/authorizer/node/graph_populator.go index c9f16efedbe..7202c1f5f90 100644 --- a/plugin/pkg/auth/authorizer/node/graph_populator.go +++ b/plugin/pkg/auth/authorizer/node/graph_populator.go @@ -157,6 +157,7 @@ func (g *graphPopulator) updatePod(oldObj, obj interface{}) { } klog.V(4).Infof("updatePod %s/%s for node %s", pod.Namespace, pod.Name, pod.Spec.NodeName) g.graph.AddPod(pod) + klog.V(4).Infof("pod %s in namespace %s is updated for the node %s", pod.Name, pod.Namespace, pod.Spec.NodeName) } func (g *graphPopulator) deletePod(obj interface{}) { @@ -174,6 +175,7 @@ func (g *graphPopulator) deletePod(obj interface{}) { } klog.V(4).Infof("deletePod %s/%s for node %s", pod.Namespace, pod.Name, pod.Spec.NodeName) g.graph.DeletePod(pod.Name, pod.Namespace) + klog.V(4).Infof("pod %s in namespace %s is deleted from the node %s", pod.Name, pod.Namespace, pod.Spec.NodeName) } func (g *graphPopulator) addPV(obj interface{}) { From 54fb058cfb4c226816a0df8535d95e214f7aad21 Mon Sep 17 00:00:00 2001 From: Shubham Kuchhal Date: Thu, 24 Feb 2022 18:33:00 +0530 Subject: [PATCH 2/3] Added timestamp and verbosity value to V(5). --- .../pkg/auth/authorizer/node/graph_populator.go | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/plugin/pkg/auth/authorizer/node/graph_populator.go b/plugin/pkg/auth/authorizer/node/graph_populator.go index 7202c1f5f90..e73ec0f87fa 100644 --- a/plugin/pkg/auth/authorizer/node/graph_populator.go +++ b/plugin/pkg/auth/authorizer/node/graph_populator.go @@ -18,6 +18,7 @@ package node import ( "fmt" + "time" "k8s.io/klog/v2" @@ -155,9 +156,13 @@ func (g *graphPopulator) updatePod(oldObj, obj interface{}) { return } } - klog.V(4).Infof("updatePod %s/%s for node %s", pod.Namespace, pod.Name, pod.Spec.NodeName) + + startTime := time.Now() + klog.V(5).Infof("updatePod %s/%s for node %s started at %s", pod.Namespace, pod.Name, pod.Spec.NodeName, startTime) g.graph.AddPod(pod) - klog.V(4).Infof("pod %s in namespace %s is updated for the node %s", pod.Name, pod.Namespace, pod.Spec.NodeName) + + endTime := time.Now() + klog.V(5).Infof("pod %s in namespace %s is updated for the node %s completed at %s", pod.Name, pod.Namespace, pod.Spec.NodeName, endTime) } func (g *graphPopulator) deletePod(obj interface{}) { @@ -173,9 +178,13 @@ func (g *graphPopulator) deletePod(obj interface{}) { klog.V(5).Infof("deletePod %s/%s, no node", pod.Namespace, pod.Name) return } - klog.V(4).Infof("deletePod %s/%s for node %s", pod.Namespace, pod.Name, pod.Spec.NodeName) + + startTime := time.Now() + klog.V(5).Infof("deletePod %s/%s for node %s started at %s", pod.Namespace, pod.Name, pod.Spec.NodeName, startTime) g.graph.DeletePod(pod.Name, pod.Namespace) - klog.V(4).Infof("pod %s in namespace %s is deleted from the node %s", pod.Name, pod.Namespace, pod.Spec.NodeName) + + endTime := time.Now() + klog.V(5).Infof("pod %s in namespace %s is deleted from the node %s completed at %s", pod.Name, pod.Namespace, pod.Spec.NodeName, endTime) } func (g *graphPopulator) addPV(obj interface{}) { From cdfbcf94fc88d5f84df09b7e268270d8726e7ddd Mon Sep 17 00:00:00 2001 From: Shubham Kuchhal Date: Fri, 25 Feb 2022 13:20:01 +0530 Subject: [PATCH 3/3] Recording the Duration. --- plugin/pkg/auth/authorizer/node/graph_populator.go | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/plugin/pkg/auth/authorizer/node/graph_populator.go b/plugin/pkg/auth/authorizer/node/graph_populator.go index e73ec0f87fa..5a21691f9a1 100644 --- a/plugin/pkg/auth/authorizer/node/graph_populator.go +++ b/plugin/pkg/auth/authorizer/node/graph_populator.go @@ -157,12 +157,10 @@ func (g *graphPopulator) updatePod(oldObj, obj interface{}) { } } + klog.V(4).Infof("updatePod %s/%s for node %s", pod.Namespace, pod.Name, pod.Spec.NodeName) startTime := time.Now() - klog.V(5).Infof("updatePod %s/%s for node %s started at %s", pod.Namespace, pod.Name, pod.Spec.NodeName, startTime) g.graph.AddPod(pod) - - endTime := time.Now() - klog.V(5).Infof("pod %s in namespace %s is updated for the node %s completed at %s", pod.Name, pod.Namespace, pod.Spec.NodeName, endTime) + klog.V(5).Infof("updatePod %s/%s for node %s completed in %v", pod.Namespace, pod.Name, pod.Spec.NodeName, time.Since(startTime)) } func (g *graphPopulator) deletePod(obj interface{}) { @@ -179,12 +177,10 @@ func (g *graphPopulator) deletePod(obj interface{}) { return } + klog.V(4).Infof("deletePod %s/%s for node %s", pod.Namespace, pod.Name, pod.Spec.NodeName) startTime := time.Now() - klog.V(5).Infof("deletePod %s/%s for node %s started at %s", pod.Namespace, pod.Name, pod.Spec.NodeName, startTime) g.graph.DeletePod(pod.Name, pod.Namespace) - - endTime := time.Now() - klog.V(5).Infof("pod %s in namespace %s is deleted from the node %s completed at %s", pod.Name, pod.Namespace, pod.Spec.NodeName, endTime) + klog.V(5).Infof("deletePod %s/%s for node %s completed in %v", pod.Namespace, pod.Name, pod.Spec.NodeName, time.Since(startTime)) } func (g *graphPopulator) addPV(obj interface{}) {