From f005ea89769f6c889b4ce381fbd0c62c6220080f Mon Sep 17 00:00:00 2001 From: Matt Matejczyk Date: Mon, 22 Oct 2018 14:14:58 -0400 Subject: [PATCH] Make it clear that the timestamp is a unix time in millis. --- pkg/apis/core/annotation_key_constants.go | 9 +++++---- .../src/k8s.io/api/core/v1/annotation_key_constants.go | 9 +++++---- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/pkg/apis/core/annotation_key_constants.go b/pkg/apis/core/annotation_key_constants.go index fd83b464887..bbe0b92220d 100644 --- a/pkg/apis/core/annotation_key_constants.go +++ b/pkg/apis/core/annotation_key_constants.go @@ -84,10 +84,11 @@ const ( AnnotationLoadBalancerSourceRangesKey = "service.beta.kubernetes.io/load-balancer-source-ranges" // EndpointsLastChangeTriggerTime is the annotation key, set for endpoints objects, that - // represents the timestamp (in milliseconds) of the last change, of some pod or service object, - // that triggered the endpoints object change. In other words, if a Pod / Service changed at time - // T0, that change was observed by endpoints controller at T1, and the Endpoints object was - // changed at T2, the EndpointsLastChangeTriggerTime would be set to T0. + // represents the timestamp (expressed as a Unix time in milliseconds, i.e. the number of + // milliseconds elapsed since January 1, 1970 UTC) of the last change, of some pod or service + // object, that triggered the endpoints object change. In other words, if a Pod / Service changed + // at time T0, that change was observed by endpoints controller at T1, and the Endpoints object + // was changed at T2, the EndpointsLastChangeTriggerTime would be set to T0. // // The "endpoints change trigger" here means any Pod or Service change that resulted in the // Endpoints object change. diff --git a/staging/src/k8s.io/api/core/v1/annotation_key_constants.go b/staging/src/k8s.io/api/core/v1/annotation_key_constants.go index 8b0f0ebef4f..7a1088ad569 100644 --- a/staging/src/k8s.io/api/core/v1/annotation_key_constants.go +++ b/staging/src/k8s.io/api/core/v1/annotation_key_constants.go @@ -80,10 +80,11 @@ const ( AnnotationLoadBalancerSourceRangesKey = "service.beta.kubernetes.io/load-balancer-source-ranges" // EndpointsLastChangeTriggerTime is the annotation key, set for endpoints objects, that - // represents the timestamp (in milliseconds) of the last change, of some pod or service object, - // that triggered the endpoints object change. In other words, if a Pod / Service changed at time - // T0, that change was observed by endpoints controller at T1, and the Endpoints object was - // changed at T2, the EndpointsLastChangeTriggerTime would be set to T0. + // represents the timestamp (expressed as a Unix time in milliseconds, i.e. the number of + // milliseconds elapsed since January 1, 1970 UTC) of the last change, of some pod or service + // object, that triggered the endpoints object change. In other words, if a Pod / Service changed + // at time T0, that change was observed by endpoints controller at T1, and the Endpoints object + // was changed at T2, the EndpointsLastChangeTriggerTime would be set to T0. // // The "endpoints change trigger" here means any Pod or Service change that resulted in the // Endpoints object change.