From 307b0630aa6ae9b65e2e35cbc5d97845ff317852 Mon Sep 17 00:00:00 2001 From: Peter Hunt Date: Tue, 25 Jul 2023 13:09:58 -0400 Subject: [PATCH 1/2] cri-api: add CRI implementation maintainers as approvers Logistically, changes in the CRI require approval of members of the associated CRI communities to sign-onto implementing them. This relationship could be more formal, as this PR proposes. The current set of people is chosen as top-level approvers of two major CRI implementations, all of whom also regularly participate in SIG-Node and are not themselves already sig-node-approvers. Signed-off-by: Peter Hunt --- OWNERS_ALIASES | 4 ++++ staging/src/k8s.io/cri-api/OWNERS | 1 + 2 files changed, 5 insertions(+) diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES index def06e4af8b..6e3fd1c331f 100644 --- a/OWNERS_ALIASES +++ b/OWNERS_ALIASES @@ -230,6 +230,10 @@ aliases: # emeretus: # - dashpole # - vishh + sig-node-cri-approvers: + - saschagrunert + - haircommander + - mikebrow sig-node-reviewers: - Random-Liu - dchen1107 diff --git a/staging/src/k8s.io/cri-api/OWNERS b/staging/src/k8s.io/cri-api/OWNERS index 06f727c77f9..c3355de36e5 100644 --- a/staging/src/k8s.io/cri-api/OWNERS +++ b/staging/src/k8s.io/cri-api/OWNERS @@ -6,6 +6,7 @@ approvers: - sig-node-approvers - sig-node-api-approvers - api-approvers + - sig-node-cri-approvers reviewers: - sig-node-reviewers - dims From 90b870b710ae79a37e0fa6f67ee23b47b4ec042d Mon Sep 17 00:00:00 2001 From: Peter Hunt Date: Tue, 1 Aug 2023 13:28:20 -0400 Subject: [PATCH 2/2] OWNERS_ALIASES: compress sig-node-{api,cri}-approvers take on new name, to clarify scope Signed-off-by: Peter Hunt --- OWNERS_ALIASES | 7 +++---- staging/src/k8s.io/cri-api/OWNERS | 1 - 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES index 6e3fd1c331f..67c5398238a 100644 --- a/OWNERS_ALIASES +++ b/OWNERS_ALIASES @@ -231,6 +231,9 @@ aliases: # - dashpole # - vishh sig-node-cri-approvers: + - msau42 + - smarterclayton + - thockin - saschagrunert - haircommander - mikebrow @@ -369,10 +372,6 @@ aliases: - caseydavenport - danwinship - thockin - sig-node-api-approvers: - - msau42 - - smarterclayton - - thockin sig-scheduling-api-approvers: - lavalamp - msau42 diff --git a/staging/src/k8s.io/cri-api/OWNERS b/staging/src/k8s.io/cri-api/OWNERS index c3355de36e5..694ffa4613b 100644 --- a/staging/src/k8s.io/cri-api/OWNERS +++ b/staging/src/k8s.io/cri-api/OWNERS @@ -4,7 +4,6 @@ approvers: - dims - feiskyer - sig-node-approvers - - sig-node-api-approvers - api-approvers - sig-node-cri-approvers reviewers: