From b2aabc540eaf58d697b3b306b6deb6ea2a7a25f0 Mon Sep 17 00:00:00 2001 From: Filipe Brandenburger Date: Wed, 21 Jan 2015 08:44:53 -0800 Subject: [PATCH] Fix kubectl version to match client and server version output Before this fix, the server version was printed from a pointer, making the Go formatter prefix it with a &. Before this patch: $ kubectl version Client Version: version.Info{Major:"0", Minor:"8+", GitVersion:"v0.8.0-509-g8537a73264b836", GitCommit:"8537a73264b836226cfca745ed37d65916e3b16f", GitTreeState:"clean"} Server Version: &version.Info{Major:"0", Minor:"8+", GitVersion:"v0.8.0-509-g8537a73264b836", GitCommit:"8537a73264b836226cfca745ed37d65916e3b16f", GitTreeState:"clean"} After this patch: $ kubectl version Client Version: version.Info{Major:"0", Minor:"8+", GitVersion:"v0.8.0-509-g8537a73264b836-dirty", GitCommit:"8537a73264b836226cfca745ed37d65916e3b16f", GitTreeState:"dirty"} Server Version: version.Info{Major:"0", Minor:"8+", GitVersion:"v0.8.0-509-g8537a73264b836", GitCommit:"8537a73264b836226cfca745ed37d65916e3b16f", GitTreeState:"clean"} --- pkg/kubectl/version.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/kubectl/version.go b/pkg/kubectl/version.go index 5c4c8e45cee..4bb6b516bc5 100644 --- a/pkg/kubectl/version.go +++ b/pkg/kubectl/version.go @@ -33,7 +33,7 @@ func GetVersion(w io.Writer, kubeClient client.Interface) { } GetClientVersion(w) - fmt.Fprintf(w, "Server Version: %#v\n", serverVersion) + fmt.Fprintf(w, "Server Version: %#v\n", *serverVersion) } func GetClientVersion(w io.Writer) {