From f0e2920898522b1baf04303faf19645978a468de Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Wed, 23 Jul 2025 09:00:53 +0200 Subject: [PATCH] DRA E2E: simplify "control plane" test names There's no need to clarify how many nodes are used in the test because the overall test names are still unique without that (verified with go test -v ./test/e2e -args -list-tests | grep -w DRA | wc -l). --- test/e2e/dra/dra.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/test/e2e/dra/dra.go b/test/e2e/dra/dra.go index bff8d9fd352..2979cb5f454 100644 --- a/test/e2e/dra/dra.go +++ b/test/e2e/dra/dra.go @@ -1750,10 +1750,13 @@ var _ = framework.SIGDescribe("node")(framework.WithLabel("DRA"), framework.With }) } - framework.Context("control plane with single node", framework.WithLabel("ConformanceCandidate") /* TODO: replace with framework.WithConformance() */, func() { singleNodeTests(false) }) + // It is okay to use the same context multiple times (like "control plane"), + // as long as the test names the still remain unique overall. + + framework.Context("control plane", framework.WithLabel("ConformanceCandidate") /* TODO: replace with framework.WithConformance() */, func() { singleNodeTests(false) }) framework.Context("kubelet", feature.DynamicResourceAllocation, "on single node", func() { singleNodeTests(true) }) - framework.Context("control plane with multiple nodes", framework.WithLabel("ConformanceCandidate") /* TODO: replace with framework.WithConformance() */, func() { multiNodeTests(false) }) + framework.Context("control plane", framework.WithLabel("ConformanceCandidate") /* TODO: replace with framework.WithConformance() */, func() { multiNodeTests(false) }) framework.Context("kubelet", feature.DynamicResourceAllocation, "on multiple nodes", func() { multiNodeTests(true) }) framework.Context("kubelet", feature.DynamicResourceAllocation, f.WithFeatureGate(features.DRAPrioritizedList), prioritizedListTests)