From 73fe9c9915522f60c1b34617ff6b00e280b4825c Mon Sep 17 00:00:00 2001 From: Shaun Crampton Date: Mon, 4 May 2020 14:32:04 +0100 Subject: [PATCH] Avoid early exit when collecting post-E2E failure logs. collectPodsAndNetworkPolicies() is called to collect diagnostics after a failure. Previously, if it encountered a failure in getting the logs it would call Failf(), discarding the rest of the diagnostics immediately. --- test/e2e/network/network_policy.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/network/network_policy.go b/test/e2e/network/network_policy.go index dfd5ff681b9..bd9e0243b7d 100644 --- a/test/e2e/network/network_policy.go +++ b/test/e2e/network/network_policy.go @@ -1829,7 +1829,7 @@ func collectPodsAndNetworkPolicies(f *framework.Framework, podClient *v1.Pod) ([ logs, logErr = e2epod.GetPreviousPodLogs(f.ClientSet, f.Namespace.Name, podClient.Name, fmt.Sprintf("%s-container", podClient.Name)) } if logErr != nil { - framework.Failf("Error getting container logs: %s", logErr) + framework.Logf("Error getting container logs: %s", logErr) } // Collect current NetworkPolicies applied in the test namespace.