mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-29 06:27:05 +00:00
Merge pull request #81547 from BenTheElder/typecheck-cleanup
typecheck cleanup
This commit is contained in:
commit
f12a40df19
@ -1,8 +1,8 @@
|
|||||||
# See the OWNERS docs at https://go.k8s.io/owners
|
# See the OWNERS docs at https://go.k8s.io/owners
|
||||||
|
|
||||||
reviewers:
|
reviewers:
|
||||||
|
- BenTheElder
|
||||||
- cblecker
|
- cblecker
|
||||||
- rmmh
|
|
||||||
approvers:
|
approvers:
|
||||||
- cblecker
|
- cblecker
|
||||||
- rmmh
|
- rmmh
|
||||||
|
@ -103,26 +103,6 @@ func newAnalyzer(platform string) *analyzer {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (a *analyzer) handleError(err error) {
|
func (a *analyzer) handleError(err error) {
|
||||||
if e, ok := err.(types.Error); ok {
|
|
||||||
// useful for some ignores:
|
|
||||||
// path := e.Fset.Position(e.Pos).String()
|
|
||||||
ignore := false
|
|
||||||
// TODO(rmmh): read ignores from a file, so this code can
|
|
||||||
// be Kubernetes-agnostic. Unused ignores should be treated as
|
|
||||||
// errors, to ensure coverage isn't overly broad.
|
|
||||||
if strings.Contains(e.Msg, "GetOpenAPIDefinitions") {
|
|
||||||
// TODO(rmmh): figure out why this happens.
|
|
||||||
// cmd/kube-apiserver/app/server.go:392:70
|
|
||||||
// test/integration/framework/master_utils.go:131:84
|
|
||||||
ignore = true
|
|
||||||
}
|
|
||||||
if ignore {
|
|
||||||
if *verbose {
|
|
||||||
fmt.Println("ignoring error:", err)
|
|
||||||
}
|
|
||||||
return
|
|
||||||
}
|
|
||||||
}
|
|
||||||
a.errors = append(a.errors, err.Error())
|
a.errors = append(a.errors, err.Error())
|
||||||
if *serial {
|
if *serial {
|
||||||
fmt.Fprintf(os.Stderr, "%sERROR(%s) %s\n", logPrefix, a.platform, err)
|
fmt.Fprintf(os.Stderr, "%sERROR(%s) %s\n", logPrefix, a.platform, err)
|
||||||
|
2
third_party/go-srcimporter/OWNERS
vendored
2
third_party/go-srcimporter/OWNERS
vendored
@ -1,8 +1,8 @@
|
|||||||
# See the OWNERS docs at https://go.k8s.io/owners
|
# See the OWNERS docs at https://go.k8s.io/owners
|
||||||
|
|
||||||
reviewers:
|
reviewers:
|
||||||
|
- BenTheElder
|
||||||
- cblecker
|
- cblecker
|
||||||
- rmmh
|
|
||||||
approvers:
|
approvers:
|
||||||
- cblecker
|
- cblecker
|
||||||
- rmmh
|
- rmmh
|
||||||
|
Loading…
Reference in New Issue
Block a user