From f16745437182ec50f51253cef39cd5c89041ee95 Mon Sep 17 00:00:00 2001 From: Paco Xu Date: Mon, 3 Mar 2025 10:54:46 +0800 Subject: [PATCH] remove feature gate AdmissionWebhookMatchConditions that was GAed in v1.30 --- pkg/features/versioned_kube_features.go | 6 ------ .../k8s.io/apiserver/pkg/features/kube_features.go | 13 ------------- .../test_data/versioned_feature_list.yaml | 14 -------------- 3 files changed, 33 deletions(-) diff --git a/pkg/features/versioned_kube_features.go b/pkg/features/versioned_kube_features.go index e43eb5132b4..18f193f1674 100644 --- a/pkg/features/versioned_kube_features.go +++ b/pkg/features/versioned_kube_features.go @@ -198,12 +198,6 @@ var defaultVersionedKubernetesFeatureGates = map[featuregate.Feature]featuregate {Version: version.MustParse("1.32"), Default: false, PreRelease: featuregate.Alpha}, }, - genericfeatures.AdmissionWebhookMatchConditions: { - {Version: version.MustParse("1.27"), Default: false, PreRelease: featuregate.Alpha}, - {Version: version.MustParse("1.28"), Default: true, PreRelease: featuregate.Beta}, - {Version: version.MustParse("1.30"), Default: true, PreRelease: featuregate.GA, LockToDefault: true}, - }, - genericfeatures.AllowParsingUserUIDFromCertAuth: { {Version: version.MustParse("1.33"), Default: true, PreRelease: featuregate.Beta}, }, diff --git a/staging/src/k8s.io/apiserver/pkg/features/kube_features.go b/staging/src/k8s.io/apiserver/pkg/features/kube_features.go index fce29818868..5da529e1e4e 100644 --- a/staging/src/k8s.io/apiserver/pkg/features/kube_features.go +++ b/staging/src/k8s.io/apiserver/pkg/features/kube_features.go @@ -34,13 +34,6 @@ const ( // of code conflicts because changes are more likely to be scattered // across the file. - // owner: @ivelichkovich, @tallclair - // stable: v1.30 - // kep: https://kep.k8s.io/3716 - // - // Enables usage of MatchConditions fields to use CEL expressions for matching on admission webhooks - AdmissionWebhookMatchConditions featuregate.Feature = "AdmissionWebhookMatchConditions" - // owner: @modulitos // // Allow user.DefaultInfo.UID to be set from x509 cert during cert auth. @@ -253,12 +246,6 @@ func init() { // Entries are alphabetized and separated from each other with blank lines to avoid sweeping gofmt changes // when adding or removing one entry. var defaultVersionedKubernetesFeatureGates = map[featuregate.Feature]featuregate.VersionedSpecs{ - AdmissionWebhookMatchConditions: { - {Version: version.MustParse("1.27"), Default: false, PreRelease: featuregate.Alpha}, - {Version: version.MustParse("1.28"), Default: true, PreRelease: featuregate.Beta}, - {Version: version.MustParse("1.30"), Default: true, PreRelease: featuregate.GA, LockToDefault: true}, - }, - AllowParsingUserUIDFromCertAuth: { {Version: version.MustParse("1.33"), Default: true, PreRelease: featuregate.Beta}, }, diff --git a/test/featuregates_linter/test_data/versioned_feature_list.yaml b/test/featuregates_linter/test_data/versioned_feature_list.yaml index 8930f1a51a6..3cde1aa4753 100644 --- a/test/featuregates_linter/test_data/versioned_feature_list.yaml +++ b/test/featuregates_linter/test_data/versioned_feature_list.yaml @@ -1,17 +1,3 @@ -- name: AdmissionWebhookMatchConditions - versionedSpecs: - - default: false - lockToDefault: false - preRelease: Alpha - version: "1.27" - - default: true - lockToDefault: false - preRelease: Beta - version: "1.28" - - default: true - lockToDefault: true - preRelease: GA - version: "1.30" - name: AllowDNSOnlyNodeCSR versionedSpecs: - default: true