From f1d0835235408ce2007fcffb91c3ee2cc13da0cf Mon Sep 17 00:00:00 2001 From: Paul Weil Date: Thu, 13 Aug 2015 14:31:56 -0400 Subject: [PATCH] don't swallow bad request errors --- pkg/kubectl/resource/selector.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/pkg/kubectl/resource/selector.go b/pkg/kubectl/resource/selector.go index d7861fd2151..90c0e21f493 100644 --- a/pkg/kubectl/resource/selector.go +++ b/pkg/kubectl/resource/selector.go @@ -17,7 +17,7 @@ limitations under the License. package resource import ( - "github.com/golang/glog" + "fmt" "k8s.io/kubernetes/pkg/api/errors" "k8s.io/kubernetes/pkg/api/meta" @@ -50,11 +50,10 @@ func (r *Selector) Visit(fn VisitorFunc) error { if err != nil { if errors.IsBadRequest(err) || errors.IsNotFound(err) { if r.Selector.Empty() { - glog.V(2).Infof("Unable to list %q: %v", r.Mapping.Resource, err) + return fmt.Errorf("Unable to list %q: %v", r.Mapping.Resource, err) } else { - glog.V(2).Infof("Unable to find %q that match the selector %q: %v", r.Mapping.Resource, r.Selector, err) + return fmt.Errorf("Unable to find %q that match the selector %q: %v", r.Mapping.Resource, r.Selector, err) } - return nil } return err }