From f1df40d5ee723eecf511bb7ef6b75b3489b362a3 Mon Sep 17 00:00:00 2001 From: zhangxiaoyu-zidif Date: Fri, 21 Apr 2017 11:12:54 +0800 Subject: [PATCH] cleancode: graph_builder.go --- pkg/controller/garbagecollector/graph_builder.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/controller/garbagecollector/graph_builder.go b/pkg/controller/garbagecollector/graph_builder.go index 1fba4751bdf..e3cb55c3c40 100644 --- a/pkg/controller/garbagecollector/graph_builder.go +++ b/pkg/controller/garbagecollector/graph_builder.go @@ -285,13 +285,13 @@ type ownerRefPair struct { // when the number of references is small. func referencesDiffs(old []metav1.OwnerReference, new []metav1.OwnerReference) (added []metav1.OwnerReference, removed []metav1.OwnerReference, changed []ownerRefPair) { oldUIDToRef := make(map[string]metav1.OwnerReference) - for i := 0; i < len(old); i++ { - oldUIDToRef[string(old[i].UID)] = old[i] + for _, value := range old { + oldUIDToRef[string(value.UID)] = value } oldUIDSet := sets.StringKeySet(oldUIDToRef) newUIDToRef := make(map[string]metav1.OwnerReference) - for i := 0; i < len(new); i++ { - newUIDToRef[string(new[i].UID)] = new[i] + for _, value := range new { + newUIDToRef[string(value.UID)] = value } newUIDSet := sets.StringKeySet(newUIDToRef)