From f21d18dbb4df91cba0cc8f27b8a5daf21a988228 Mon Sep 17 00:00:00 2001 From: Michael Fritch Date: Thu, 4 Sep 2025 11:00:13 -0600 Subject: [PATCH] Don't Panic, everything is fine control plane components share global DefaultFeatureGate/DefaultMutableFeatureGate variables See also: https://github.com/kubernetes/kubernetes/compare/9497222ae2af953dc644dacca450ecc8ce34e3fc..db342010f46d14903bc1e0cf62ab8bfb70c5eb46 Signed-off-by: Michael Fritch --- cmd/kube-controller-manager/app/options/options.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/kube-controller-manager/app/options/options.go b/cmd/kube-controller-manager/app/options/options.go index 867cd8d3250..2a5b5626023 100644 --- a/cmd/kube-controller-manager/app/options/options.go +++ b/cmd/kube-controller-manager/app/options/options.go @@ -47,6 +47,7 @@ import ( logsapi "k8s.io/component-base/logs/api/v1" "k8s.io/component-base/metrics" cmoptions "k8s.io/controller-manager/options" + "k8s.io/klog/v2" kubectrlmgrconfigv1alpha1 "k8s.io/kube-controller-manager/config/v1alpha1" kubecontrollerconfig "k8s.io/kubernetes/cmd/kube-controller-manager/app/config" "k8s.io/kubernetes/cmd/kube-controller-manager/names" @@ -314,7 +315,7 @@ func (s *KubeControllerManagerOptions) Flags(allControllers []string, disabledBy if !utilfeature.DefaultFeatureGate.Enabled(featuregate.Feature(clientgofeaturegate.WatchListClient)) { ver := version.MustParse("1.34") if err := utilfeature.DefaultMutableFeatureGate.OverrideDefaultAtVersion(featuregate.Feature(clientgofeaturegate.WatchListClient), true, ver); err != nil { - panic(fmt.Sprintf("unable to set %s feature gate, err: %v", clientgofeaturegate.WatchListClient, err)) + klog.Infof(fmt.Sprintf("unable to set %s feature gate, err: %v", clientgofeaturegate.WatchListClient, err)) } }