From f26f896128709350e980eb71fbdd9edd39b26494 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Tue, 14 Mar 2023 19:17:31 +0100 Subject: [PATCH] hack/logcheck.conf: enforce contextual logging in kube-controller-manager Not all PRs made it into 1.27, but enough that it is now easier to list the exceptions. --- hack/logcheck.conf | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/hack/logcheck.conf b/hack/logcheck.conf index f410c91c03f..5161fc58878 100644 --- a/hack/logcheck.conf +++ b/hack/logcheck.conf @@ -29,9 +29,37 @@ structured k8s.io/apiserver/pkg/server/options/encryptionconfig/.* # TODO next: contextual k8s.io/kubernetes/pkg/scheduler/.* # A few files involved in startup migrated already to contextual # We can't enable contextual logcheck until all are migrated -contextual k8s.io/kubernetes/test/e2e/dra/.* contextual k8s.io/dynamic-resource-allocation/.* +contextual k8s.io/kubernetes/cmd/kube-controller-manager/.* contextual k8s.io/kubernetes/cmd/kube-scheduler/.* +contextual k8s.io/kubernetes/pkg/controller/.* +contextual k8s.io/kubernetes/test/e2e/dra/.* + +# Most of kube-controller-manager has been converted, but not everything. At +# this point it is easier to list the exceptions. +-contextual k8s.io/kubernetes/pkg/controller/certificates/.* +-contextual k8s.io/kubernetes/pkg/controller/controller_ref_manager.go +-contextual k8s.io/kubernetes/pkg/controller/controller_utils.go +-contextual k8s.io/kubernetes/pkg/controller/deployment/.* +-contextual k8s.io/kubernetes/pkg/controller/disruption/.* +-contextual k8s.io/kubernetes/pkg/controller/endpoint/.* +-contextual k8s.io/kubernetes/pkg/controller/endpointslice/.* +-contextual k8s.io/kubernetes/pkg/controller/endpointslicemirroring/.* +-contextual k8s.io/kubernetes/pkg/controller/garbagecollector/.* +-contextual k8s.io/kubernetes/pkg/controller/job/.* +-contextual k8s.io/kubernetes/pkg/controller/nodeipam/.* +-contextual k8s.io/kubernetes/pkg/controller/podgc/.* +-contextual k8s.io/kubernetes/pkg/controller/replicaset/.* +-contextual k8s.io/kubernetes/pkg/controller/statefulset/.* +-contextual k8s.io/kubernetes/pkg/controller/testutil/.* +-contextual k8s.io/kubernetes/pkg/controller/util/.* +-contextual k8s.io/kubernetes/pkg/controller/volume/attachdetach/attach_detach_controller.go +-contextual k8s.io/kubernetes/pkg/controller/volume/attachdetach/testing/testvolumespec.go +-contextual k8s.io/kubernetes/pkg/controller/volume/expand/expand_controller.go +-contextual k8s.io/kubernetes/pkg/controller/volume/persistentvolume/pv_controller_test.go +-contextual k8s.io/kubernetes/pkg/controller/volume/persistentvolume/volume_host.go +-contextual k8s.io/kubernetes/pkg/controller/volume/pvcprotection/pvc_protection_controller_test.go +-contextual k8s.io/kubernetes/pkg/controller/volume/pvprotection/pv_protection_controller_test.go # As long as contextual logging is alpha or beta, all WithName, WithValues, # NewContext calls have to go through klog. Once it is GA, we can lift