From f2fcf659fc8c4ddb05b32bc6616339fb9bb8c385 Mon Sep 17 00:00:00 2001 From: "Alvaro [Andor]" Date: Fri, 18 Nov 2016 16:17:25 +0100 Subject: [PATCH] Fix renaming order shown on terminal When finishing a rolling update, a message is shown : 'Renaming oldRc to newRc' In my case that'd be: 'Renaming nginx to nginx-df8d9fafc5007d83968cd37c8353d52e' That naming order is incorrect, as the new name is temporary, and the final name should be the old one --- pkg/kubectl/rolling_updater.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/kubectl/rolling_updater.go b/pkg/kubectl/rolling_updater.go index 76c14d976f2..b15125cd2ee 100644 --- a/pkg/kubectl/rolling_updater.go +++ b/pkg/kubectl/rolling_updater.go @@ -520,7 +520,7 @@ func (r *RollingUpdater) cleanupWithClients(oldRc, newRc *api.ReplicationControl if err := r.rcClient.ReplicationControllers(r.ns).Delete(oldRc.Name, nil); err != nil { return err } - fmt.Fprintf(config.Out, "Renaming %s to %s\n", oldRc.Name, newRc.Name) + fmt.Fprintf(config.Out, "Renaming %s to %s\n", newRc.Name, oldRc.Name) return Rename(r.rcClient, newRc, oldRc.Name) case PreserveRollingUpdateCleanupPolicy: return nil