mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-08-03 17:30:00 +00:00
Merge pull request #128470 from omerap12/autoscale-unit
kubectl: add test coverage for autoscale command
This commit is contained in:
Kubernetes Prow Robot
GitHub
commit
f4d05aad77
298
staging/src/k8s.io/kubectl/pkg/cmd/autoscale/autoscale_test.go
Normal file
298
staging/src/k8s.io/kubectl/pkg/cmd/autoscale/autoscale_test.go
Normal file
@ -0,0 +1,298 @@
|
|||||||
|
/*
|
||||||
|
Copyright 2024 The Kubernetes Authors.
|
||||||
|
|
||||||
|
Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
you may not use this file except in compliance with the License.
|
||||||
|
You may obtain a copy of the License at
|
||||||
|
|
||||||
|
http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
|
||||||
|
Unless required by applicable law or agreed to in writing, software
|
||||||
|
distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
See the License for the specific language governing permissions and
|
||||||
|
limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package autoscale
|
||||||
|
|
||||||
|
import (
|
||||||
|
"fmt"
|
||||||
|
"testing"
|
||||||
|
|
||||||
|
"github.com/stretchr/testify/assert"
|
||||||
|
|
||||||
|
autoscalingv1 "k8s.io/api/autoscaling/v1"
|
||||||
|
"k8s.io/apimachinery/pkg/api/meta"
|
||||||
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
||||||
|
"k8s.io/apimachinery/pkg/runtime/schema"
|
||||||
|
"k8s.io/utils/ptr"
|
||||||
|
)
|
||||||
|
|
||||||
|
type validateTestCase struct {
|
||||||
|
name string
|
||||||
|
options *AutoscaleOptions
|
||||||
|
expectedError error
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestAutoscaleValidate(t *testing.T) {
|
||||||
|
tests := []validateTestCase{
|
||||||
|
{
|
||||||
|
name: "valid options",
|
||||||
|
options: &AutoscaleOptions{
|
||||||
|
Max: 10,
|
||||||
|
Min: 1,
|
||||||
|
},
|
||||||
|
expectedError: nil,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "max less than 1",
|
||||||
|
options: &AutoscaleOptions{
|
||||||
|
Max: 0,
|
||||||
|
Min: 1,
|
||||||
|
},
|
||||||
|
expectedError: fmt.Errorf("--max=MAXPODS is required and must be at least 1, max: 0"),
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "min greater than max",
|
||||||
|
options: &AutoscaleOptions{
|
||||||
|
Max: 1,
|
||||||
|
Min: 2,
|
||||||
|
},
|
||||||
|
expectedError: fmt.Errorf("--max=MAXPODS must be larger or equal to --min=MINPODS, max: 1, min: 2"),
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "zero min replicas",
|
||||||
|
options: &AutoscaleOptions{
|
||||||
|
Max: 5,
|
||||||
|
Min: 0,
|
||||||
|
},
|
||||||
|
expectedError: nil,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "negative min replicas",
|
||||||
|
options: &AutoscaleOptions{
|
||||||
|
Max: 5,
|
||||||
|
Min: -2,
|
||||||
|
},
|
||||||
|
expectedError: nil,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
for _, tc := range tests {
|
||||||
|
t.Run(tc.name, func(t *testing.T) {
|
||||||
|
errorGot := tc.options.Validate()
|
||||||
|
assert.Equal(t, tc.expectedError, errorGot)
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
type createHorizontalPodAutoscalerTestCase struct {
|
||||||
|
name string
|
||||||
|
options *AutoscaleOptions
|
||||||
|
refName string
|
||||||
|
mapping *meta.RESTMapping
|
||||||
|
expectedHPA *autoscalingv1.HorizontalPodAutoscaler
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestCreateHorizontalPodAutoscaler(t *testing.T) {
|
||||||
|
tests := []createHorizontalPodAutoscalerTestCase{
|
||||||
|
{
|
||||||
|
name: "create with all options",
|
||||||
|
options: &AutoscaleOptions{
|
||||||
|
Name: "custom-name",
|
||||||
|
Max: 10,
|
||||||
|
Min: 2,
|
||||||
|
CPUPercent: 80,
|
||||||
|
},
|
||||||
|
refName: "deployment-1",
|
||||||
|
mapping: &meta.RESTMapping{
|
||||||
|
GroupVersionKind: schema.GroupVersionKind{
|
||||||
|
Group: "apps",
|
||||||
|
Version: "v1",
|
||||||
|
Kind: "Deployment",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectedHPA: &autoscalingv1.HorizontalPodAutoscaler{
|
||||||
|
ObjectMeta: metav1.ObjectMeta{
|
||||||
|
Name: "custom-name",
|
||||||
|
},
|
||||||
|
Spec: autoscalingv1.HorizontalPodAutoscalerSpec{
|
||||||
|
ScaleTargetRef: autoscalingv1.CrossVersionObjectReference{
|
||||||
|
APIVersion: "apps/v1",
|
||||||
|
Kind: "Deployment",
|
||||||
|
Name: "deployment-1",
|
||||||
|
},
|
||||||
|
MinReplicas: ptr.To(int32(2)),
|
||||||
|
MaxReplicas: int32(10),
|
||||||
|
TargetCPUUtilizationPercentage: ptr.To(int32(80)),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "create without min replicas",
|
||||||
|
options: &AutoscaleOptions{
|
||||||
|
Name: "custom-name-2",
|
||||||
|
Max: 10,
|
||||||
|
Min: -1,
|
||||||
|
CPUPercent: 80,
|
||||||
|
},
|
||||||
|
refName: "deployment-2",
|
||||||
|
mapping: &meta.RESTMapping{
|
||||||
|
GroupVersionKind: schema.GroupVersionKind{
|
||||||
|
Group: "apps",
|
||||||
|
Version: "v1",
|
||||||
|
Kind: "Deployment",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectedHPA: &autoscalingv1.HorizontalPodAutoscaler{
|
||||||
|
ObjectMeta: metav1.ObjectMeta{
|
||||||
|
Name: "custom-name-2",
|
||||||
|
},
|
||||||
|
Spec: autoscalingv1.HorizontalPodAutoscalerSpec{
|
||||||
|
ScaleTargetRef: autoscalingv1.CrossVersionObjectReference{
|
||||||
|
APIVersion: "apps/v1",
|
||||||
|
Kind: "Deployment",
|
||||||
|
Name: "deployment-2",
|
||||||
|
},
|
||||||
|
MinReplicas: nil,
|
||||||
|
MaxReplicas: int32(10),
|
||||||
|
TargetCPUUtilizationPercentage: ptr.To(int32(80)),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "create without max replicas",
|
||||||
|
options: &AutoscaleOptions{
|
||||||
|
Name: "custom-name-3",
|
||||||
|
Max: -1,
|
||||||
|
Min: 2,
|
||||||
|
CPUPercent: 80,
|
||||||
|
},
|
||||||
|
refName: "deployment-3",
|
||||||
|
mapping: &meta.RESTMapping{
|
||||||
|
GroupVersionKind: schema.GroupVersionKind{
|
||||||
|
Group: "apps",
|
||||||
|
Version: "v1",
|
||||||
|
Kind: "Deployment",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectedHPA: &autoscalingv1.HorizontalPodAutoscaler{
|
||||||
|
ObjectMeta: metav1.ObjectMeta{
|
||||||
|
Name: "custom-name-3",
|
||||||
|
},
|
||||||
|
Spec: autoscalingv1.HorizontalPodAutoscalerSpec{
|
||||||
|
ScaleTargetRef: autoscalingv1.CrossVersionObjectReference{
|
||||||
|
APIVersion: "apps/v1",
|
||||||
|
Kind: "Deployment",
|
||||||
|
Name: "deployment-3",
|
||||||
|
},
|
||||||
|
MinReplicas: ptr.To(int32(2)),
|
||||||
|
MaxReplicas: int32(-1),
|
||||||
|
TargetCPUUtilizationPercentage: ptr.To(int32(80)),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "create without cpu utilization",
|
||||||
|
options: &AutoscaleOptions{
|
||||||
|
Name: "custom-name-4",
|
||||||
|
Max: 10,
|
||||||
|
Min: 2,
|
||||||
|
CPUPercent: -1,
|
||||||
|
},
|
||||||
|
refName: "deployment-4",
|
||||||
|
mapping: &meta.RESTMapping{
|
||||||
|
GroupVersionKind: schema.GroupVersionKind{
|
||||||
|
Group: "apps",
|
||||||
|
Version: "v1",
|
||||||
|
Kind: "Deployment",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectedHPA: &autoscalingv1.HorizontalPodAutoscaler{
|
||||||
|
ObjectMeta: metav1.ObjectMeta{
|
||||||
|
Name: "custom-name-4",
|
||||||
|
},
|
||||||
|
Spec: autoscalingv1.HorizontalPodAutoscalerSpec{
|
||||||
|
ScaleTargetRef: autoscalingv1.CrossVersionObjectReference{
|
||||||
|
APIVersion: "apps/v1",
|
||||||
|
Kind: "Deployment",
|
||||||
|
Name: "deployment-4",
|
||||||
|
},
|
||||||
|
MinReplicas: ptr.To(int32(2)),
|
||||||
|
MaxReplicas: int32(10),
|
||||||
|
TargetCPUUtilizationPercentage: nil,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "create with replicaset reference",
|
||||||
|
options: &AutoscaleOptions{
|
||||||
|
Name: "replicaset-hpa",
|
||||||
|
Max: 5,
|
||||||
|
Min: 1,
|
||||||
|
CPUPercent: 70,
|
||||||
|
},
|
||||||
|
refName: "frontend",
|
||||||
|
mapping: &meta.RESTMapping{
|
||||||
|
GroupVersionKind: schema.GroupVersionKind{
|
||||||
|
Group: "apps",
|
||||||
|
Version: "v1",
|
||||||
|
Kind: "ReplicaSet",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectedHPA: &autoscalingv1.HorizontalPodAutoscaler{
|
||||||
|
ObjectMeta: metav1.ObjectMeta{
|
||||||
|
Name: "replicaset-hpa",
|
||||||
|
},
|
||||||
|
Spec: autoscalingv1.HorizontalPodAutoscalerSpec{
|
||||||
|
ScaleTargetRef: autoscalingv1.CrossVersionObjectReference{
|
||||||
|
APIVersion: "apps/v1",
|
||||||
|
Kind: "ReplicaSet",
|
||||||
|
Name: "frontend",
|
||||||
|
},
|
||||||
|
MinReplicas: ptr.To(int32(1)),
|
||||||
|
MaxReplicas: int32(5),
|
||||||
|
TargetCPUUtilizationPercentage: ptr.To(int32(70)),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "create with statefulset reference",
|
||||||
|
options: &AutoscaleOptions{
|
||||||
|
Name: "statefulset-hpa",
|
||||||
|
Max: 8,
|
||||||
|
Min: 2,
|
||||||
|
CPUPercent: 60,
|
||||||
|
},
|
||||||
|
refName: "web",
|
||||||
|
mapping: &meta.RESTMapping{
|
||||||
|
GroupVersionKind: schema.GroupVersionKind{
|
||||||
|
Group: "apps",
|
||||||
|
Version: "v1",
|
||||||
|
Kind: "StatefulSet",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectedHPA: &autoscalingv1.HorizontalPodAutoscaler{
|
||||||
|
ObjectMeta: metav1.ObjectMeta{
|
||||||
|
Name: "statefulset-hpa",
|
||||||
|
},
|
||||||
|
Spec: autoscalingv1.HorizontalPodAutoscalerSpec{
|
||||||
|
ScaleTargetRef: autoscalingv1.CrossVersionObjectReference{
|
||||||
|
APIVersion: "apps/v1",
|
||||||
|
Kind: "StatefulSet",
|
||||||
|
Name: "web",
|
||||||
|
},
|
||||||
|
MinReplicas: ptr.To(int32(2)),
|
||||||
|
MaxReplicas: int32(8),
|
||||||
|
TargetCPUUtilizationPercentage: ptr.To(int32(60)),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
}
|
||||||
|
for _, tc := range tests {
|
||||||
|
t.Run(tc.name, func(t *testing.T) {
|
||||||
|
hpa := tc.options.createHorizontalPodAutoscaler(tc.refName, tc.mapping)
|
||||||
|
assert.Equal(t, tc.expectedHPA, hpa)
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
Loading…
Reference in New Issue
Block a user