github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-04 09:49:50 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #51053 from thockin/conversion-gen-debug

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 51114, 51233, 51024, 51053, 51197)

Add debug logs to conversion-gen

These were useful when tracking a different problem.
This commit is contained in:
Kubernetes Submit Queue 2017-08-25 06:22:17 -07:00 committed by GitHub
commit f65ec4f2ae
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
staging/src/k8s.io/code-generator/cmd/conversion-gen/generators/conversion.go
View File

@ -133,6 +133,8 @@ type conversionFuncMap map[conversionPair]*types.Type
// Returns all manually-defined conversion functions in the package. // Returns all manually-defined conversion functions in the package.
func getManualConversionFunctions(context *generator.Context, pkg *types.Package, manualMap conversionFuncMap) { func getManualConversionFunctions(context *generator.Context, pkg *types.Package, manualMap conversionFuncMap) {
glog.V(5).Infof("Scanning for conversion functions in %v", pkg.Name)
scopeName := types.Ref(conversionPackagePath, "Scope").Name scopeName := types.Ref(conversionPackagePath, "Scope").Name
errorName := types.Ref("", "error").Name errorName := types.Ref("", "error").Name
buffer := &bytes.Buffer{} buffer := &bytes.Buffer{}
@ -147,22 +149,27 @@ func getManualConversionFunctions(context *generator.Context, pkg *types.Package
glog.Errorf("Function without signature: %#v", f) glog.Errorf("Function without signature: %#v", f)
continue continue
} }
glog.V(8).Infof("Considering function %s", f.Name)
signature := f.Underlying.Signature signature := f.Underlying.Signature
// Check whether the function is conversion function. // Check whether the function is conversion function.
// Note that all of them have signature: // Note that all of them have signature:
// func Convert_inType_To_outType(inType, outType, conversion.Scope) error // func Convert_inType_To_outType(inType, outType, conversion.Scope) error
if signature.Receiver != nil { if signature.Receiver != nil {
glog.V(8).Infof("%s has a receiver", f.Name)
continue continue
} }
if len(signature.Parameters) != 3 || signature.Parameters[2].Name != scopeName { if len(signature.Parameters) != 3 || signature.Parameters[2].Name != scopeName {
glog.V(8).Infof("%s has wrong parameters", f.Name)
continue continue
} }
if len(signature.Results) != 1 || signature.Results[0].Name != errorName { if len(signature.Results) != 1 || signature.Results[0].Name != errorName {
glog.V(8).Infof("%s has wrong results", f.Name)
continue continue
} }
inType := signature.Parameters[0] inType := signature.Parameters[0]
outType := signature.Parameters[1] outType := signature.Parameters[1]
if inType.Kind != types.Pointer || outType.Kind != types.Pointer { if inType.Kind != types.Pointer || outType.Kind != types.Pointer {
glog.V(8).Infof("%s has wrong parameter types", f.Name)
continue continue
} }
// Now check if the name satisfies the convention. // Now check if the name satisfies the convention.
@ -170,12 +177,15 @@ func getManualConversionFunctions(context *generator.Context, pkg *types.Package
args := argsFromType(inType.Elem, outType.Elem) args := argsFromType(inType.Elem, outType.Elem)
sw.Do("Convert_$.inType|public$_To_$.outType|public$", args) sw.Do("Convert_$.inType|public$_To_$.outType|public$", args)
if f.Name.Name == buffer.String() { if f.Name.Name == buffer.String() {
glog.V(4).Infof("Found conversion function %s", f.Name)
key := conversionPair{inType.Elem, outType.Elem} key := conversionPair{inType.Elem, outType.Elem}
// We might scan the same package twice, and that's OK. // We might scan the same package twice, and that's OK.
if v, ok := manualMap[key]; ok && v != nil && v.Name.Package != pkg.Path { if v, ok := manualMap[key]; ok && v != nil && v.Name.Package != pkg.Path {
panic(fmt.Sprintf("duplicate static conversion defined: %s -> %s", key.inType, key.outType)) panic(fmt.Sprintf("duplicate static conversion defined: %s -> %s", key.inType, key.outType))
} }
manualMap[key] = f manualMap[key] = f
} else {
glog.V(8).Infof("%s has wrong name", f.Name)
} }
buffer.Reset() buffer.Reset()
} }